[LU-17398] Quash rpmbuild false warning due to %() in comment

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0
• Severity: 3
• Assignee: Shaun Tancheff
• Reporter: Shaun Tancheff

Description

rpmbuild reports the following warning:

00:08:26.905 sh: -c: line 0: syntax error near unexpected token `)'
00:08:26.905 sh: -c: line 0: `)'
00:08:26.905 warning: Macro expanded in comment on line 261: %()

However the root cause if this entire 3 lines of warning is a %() found in comment.
Rewrite the comment to escape the %() as %%() ... and suppress the warning.

Issue Links

• is related to: LU-17487 parsing --with-o2ib fails
• is related to: LU-16967 Split LNDs into sub-packages so MOFED and in-kernel OFED can co-exist in the same repo

Comments

[Shuichi Ihara]

this patch contains a regression. see LU-17487

[Peter Jones]

Merged for 2.16

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/53613/
Subject: LU-17398 build: detect mlnx-ofa_kernel-devel contents
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3c66185c84c94c47f5d8031b92165c68ef666e0e

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/53604/
Subject: LU-17398 build: quash rpmbuild false warning
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fdab3f6455c99072d2b4e93e176432cd7f5d3c2f

[Andreas Dilger]

The most recent version of patch https://review.whamcloud.com/53613 "LU-17398 build: detect mlnx-ofa_kernel-devel contents" resolves the MOFED build issue.

[Minh Diep]

610 WITH_O2IB=""
611 %if %{with mofed}
612 ▶·······o2ib_path=$(find /usr/src/ofa_kernel/ -type d -name ofed_scripts | xargs dirname)
613 ▶·······if [ -z "$o2ib_path" ]; then 

Need to check if /usr/src/ofa_kernel exists

[Andreas Dilger]

The 53604 patch resolved the syntax error/warning, but 53613 has not yet resolved the MOFED IB build failure, though it has changed the mode of failure. It no longer complains about BuildRequires but hits an error later during the build (you may not be able to access the URL, but this is the lustre-reviews-ib-6871-x86_86.txt log that is attached):
https://build.whamcloud.com/job/lustre-reviews-ib/6871/arch=x86_64,build_type=client,distro=el9.1,ib_stack=mlx/console

00:07:30.741 + export OMPI_MCA_rmaps_base_oversubscribe=1
00:07:30.741 + OMPI_MCA_rmaps_base_oversubscribe=1
00:07:30.741 + WITH_O2IB=
00:07:30.741 ++ find /usr/src/ofa_kernel/ -type d -name ofed_scripts
00:07:30.742 ++ xargs dirname
00:07:30.743 find: '/usr/src/ofa_kernel/': No such file or directory
00:07:30.743 dirname: missing operand
00:07:30.743 Try 'dirname --help' for more information.
00:07:30.744 + o2ib_path=
00:07:30.744 error: Bad exit status from /tmp/rpmbuild-lustre-jenkins-szUKCBIl/TMP/rpm-tmp.UzokKA (%build) 

[Andreas Dilger]

I've attached logs from the failed builds:

• lustre-master-next-756-x86_86.txt patch https://review.whamcloud.com/53604 "LU-17398 build: quash rpmbuild false warning"
• lustre-reviews-ib-6871-x86_86.txt patch https://review.whamcloud.com/53613 "LU-17398 build: detect mlnx-ofa_kernel-devel contents"

[Gerrit Updater]

"Shaun Tancheff <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53613
Subject: LU-17398 build: detect mlnx-ofa_kernel-devel contents
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a16751e16167be9caa1a79a412817815d64e84b9

[Gerrit Updater]

"Shaun Tancheff <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53604
Subject: LU-17398 build: quash rpmbuild false warning
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 51b601b66792ee5b0e594b540f323c39fd427330