Details

    • Technical task
    • Resolution: Fixed
    • Minor
    • Lustre 2.7.0
    • Lustre 2.4.0
    • None

    Description

      Tracking for minor cleanups suggested by sparse checker.

      Attachments

        Issue Links

          Activity

            [LU-2675] clang: code cleanups for sparse static analyzer

            Patch landed to Master.
            Please open a new specific ticket if there is any additional work needed.

            jlevi Jodi Levi (Inactive) added a comment - Patch landed to Master. Please open a new specific ticket if there is any additional work needed.

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12849/
            Subject: LU-2675 llite: remove lli_lvb
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 0c6776db8cce84fd623c76a18df93759f2fcaed4

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12849/ Subject: LU-2675 llite: remove lli_lvb Project: fs/lustre-release Branch: master Current Patch Set: Commit: 0c6776db8cce84fd623c76a18df93759f2fcaed4
            jhammond John Hammond added a comment -

            Isaac,

            Yes. I will push a patch eventually to do this. I would like to sort out the headers a bit first. lib-types.h contains some structures and defines that are shared by kernel space and user space, and some that are kernel only. I could move the shared stuff to lnet/types.h, or to some other header, or to a new header. Once it is clear which headers are shared I will unifdef _KERNEL_ all the others along with the appropriate .c files.

            jhammond John Hammond added a comment - Isaac, Yes. I will push a patch eventually to do this. I would like to sort out the headers a bit first. lib-types.h contains some structures and defines that are shared by kernel space and user space, and some that are kernel only. I could move the shared stuff to lnet/types.h, or to some other header, or to a new header. Once it is clear which headers are shared I will unifdef _ KERNEL _ all the others along with the appropriate .c files.

            Now that the lnet/ulnds code has been removed, the code under lnet/lnet that supports userspace LNDs should be removed as well. To find such code, just:

            grep __KERNEL__ lnet/lnet/*.[ch]
            
            isaac Isaac Huang (Inactive) added a comment - Now that the lnet/ulnds code has been removed, the code under lnet/lnet that supports userspace LNDs should be removed as well. To find such code, just: grep __KERNEL__ lnet/lnet/*.[ch]

            John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12932
            Subject: LU-2675 lnet: remove lnet/include/lnet/linux/
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: daa878f5b16c45809609534abec8035414a1d3dc

            gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12932 Subject: LU-2675 lnet: remove lnet/include/lnet/linux/ Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: daa878f5b16c45809609534abec8035414a1d3dc

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12231/
            Subject: LU-2675 obd: remove client_obd_lock_t
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 79c00733d0b4f8662b630fa2c6c1d475eb7556d2

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12231/ Subject: LU-2675 obd: remove client_obd_lock_t Project: fs/lustre-release Branch: master Current Patch Set: Commit: 79c00733d0b4f8662b630fa2c6c1d475eb7556d2

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12117/
            Subject: LU-2675 lnet: remove ulnds
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 86b8c3319b01e5ab03b1285012db1c7b18ddd908

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12117/ Subject: LU-2675 lnet: remove ulnds Project: fs/lustre-release Branch: master Current Patch Set: Commit: 86b8c3319b01e5ab03b1285012db1c7b18ddd908

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12115/
            Subject: LU-2675 lmv: remove lmv_init_

            {lock,unlock}

            ()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 7c814c2971be916520bd552f44173b41140ebac6

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12115/ Subject: LU-2675 lmv: remove lmv_init_ {lock,unlock} () Project: fs/lustre-release Branch: master Current Patch Set: Commit: 7c814c2971be916520bd552f44173b41140ebac6

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12113/
            Subject: LU-2675 md: remove unused code from md_object.h
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: e18a3a687ccc08fa3907f2687c0a3da30fd79958

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12113/ Subject: LU-2675 md: remove unused code from md_object.h Project: fs/lustre-release Branch: master Current Patch Set: Commit: e18a3a687ccc08fa3907f2687c0a3da30fd79958

            John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12922
            Subject: LU-2675 obd: remove destroy cookie handling
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: bb3e63fd06dd9545326ba6ed773fe6734abe695d

            gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12922 Subject: LU-2675 obd: remove destroy cookie handling Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: bb3e63fd06dd9545326ba6ed773fe6734abe695d

            John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12893
            Subject: LU-2675 mdc: remove mdc_sendpage()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: b37b334193fc18b43ea3b0689c5746da8171255e

            gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12893 Subject: LU-2675 mdc: remove mdc_sendpage() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: b37b334193fc18b43ea3b0689c5746da8171255e

            People

              jhammond John Hammond
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: