[LU-2675] clang: code cleanups for sparse static analyzer

• Type: Technical task
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.4.0

Epic

RoDC cleanup

• Assignee: John Hammond
• Reporter: John Hammond

Description

Tracking for minor cleanups suggested by sparse checker.

Issue Links

• is related to: LU-4962 oops in ll_intent_file_open() during migration
• is related to: LUDOC-349 remove documentation of obsolete loadgen tool
• is related to: LU-871 clang: minor code cleanups
• is related to: LU-8599 Restore lshowmount utility

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12851/
Subject: LU-2675 llapi: find_param cleanup part II
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 530763d717189fd57c48b352ba4d13a751a2ba64

[Isaac Huang (Inactive)]

Also, many Doxygen comments over lnet APIs (those whose names begin with LNet) include stuff that only applies to user space. Those can be removed as well.

[Amir Shehata (Inactive)]

As part of this change we should ensure that we remove the_lnet.ln_eq_waitni and associated logic, since this is not used at all for the LNet Kernel code.

[Jodi Levi (Inactive)]

Patch landed to Master.
Please open a new specific ticket if there is any additional work needed.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12849/
Subject: LU-2675 llite: remove lli_lvb
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0c6776db8cce84fd623c76a18df93759f2fcaed4

[John Hammond]

Isaac,

Yes. I will push a patch eventually to do this. I would like to sort out the headers a bit first. lib-types.h contains some structures and defines that are shared by kernel space and user space, and some that are kernel only. I could move the shared stuff to lnet/types.h, or to some other header, or to a new header. Once it is clear which headers are shared I will unifdef _KERNEL_ all the others along with the appropriate .c files.

[Isaac Huang (Inactive)]

Now that the lnet/ulnds code has been removed, the code under lnet/lnet that supports userspace LNDs should be removed as well. To find such code, just:

grep __KERNEL__ lnet/lnet/*.[ch]

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/12932
Subject: LU-2675 lnet: remove lnet/include/lnet/linux/
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: daa878f5b16c45809609534abec8035414a1d3dc

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12231/
Subject: LU-2675 obd: remove client_obd_lock_t
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 79c00733d0b4f8662b630fa2c6c1d475eb7556d2

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12117/
Subject: LU-2675 lnet: remove ulnds
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 86b8c3319b01e5ab03b1285012db1c7b18ddd908

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12115/
Subject: LU-2675 lmv: remove lmv_init_

{lock,unlock}

()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7c814c2971be916520bd552f44173b41140ebac6