Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-2875

Remove LASSERT()s on return values from req_capsule_client_get() and similar

Details

    • Task
    • Resolution: Fixed
    • Major
    • Lustre 2.6.0
    • Lustre 2.4.0, Lustre 2.5.0
    • None
    • 6949

    Attachments

      Issue Links

        is related to

        Bug - A problem which impairs or prevents the functions of the product. LU-3765 2.5.0<->2.1.5 interop: sanity test 24u: (mdt_handler.c:224:mdt_lock_pdo_init()) ASSERTION( namelen > 0 ) failed

        • Blocker - Blocks development and/or testing work, production could not run.
        • Resolved
        is related to

        Bug - A problem which impairs or prevents the functions of the product. LU-4629 Issues found by static analysis tools

        • Critical - Crashes, loss of data, severe memory leak.
        • Resolved

        Activity

          [LU-2875] Remove LASSERT()s on return values from req_capsule_client_get() and similar
          adilger Andreas Dilger added a comment -

          Does Dmitry's http://review.whamcloud.com/9276 patch address these issues, and can this bug be closed?

          adilger Andreas Dilger added a comment - Does Dmitry's http://review.whamcloud.com/9276 patch address these issues, and can this bug be closed?
          jhammond John Hammond added a comment -

          This issue was opened after a read of the MDT code and some discussion with Oleg. Change 7961 was inspired by LU-3765. AFAIK there are no interop situations that LBUG or Oops on bad name handling but I assume there are some corner cases out there.

          jhammond John Hammond added a comment - This issue was opened after a read of the MDT code and some discussion with Oleg. Change 7961 was inspired by LU-3765 . AFAIK there are no interop situations that LBUG or Oops on bad name handling but I assume there are some corner cases out there.
          adilger Andreas Dilger added a comment -

          Would be nice to have a short description of the source of this bug (static code analysis, code inspection, defect hit during testing, etc) to be able to determine the urgency of landing the patch.

          adilger Andreas Dilger added a comment - Would be nice to have a short description of the source of this bug (static code analysis, code inspection, defect hit during testing, etc) to be able to determine the urgency of landing the patch.
          jhammond John Hammond added a comment -

          Please see http://review.whamcloud.com/#/c/7961/ for a patch to make name (rr_name and rr_tgt) handling safer in the MDT layer.

          jhammond John Hammond added a comment - Please see http://review.whamcloud.com/#/c/7961/ for a patch to make name (rr_name and rr_tgt) handling safer in the MDT layer.
          jhammond John Hammond added a comment -

          Also ensure that -EPROTO (rather than -EFAULT or other) is returned where req_capsule_client_get() fails.

          jhammond John Hammond added a comment - Also ensure that -EPROTO (rather than -EFAULT or other) is returned where req_capsule_client_get() fails.

          People

            jhammond John Hammond
            jhammond John Hammond
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: