[LU-3498] most uses of IS_ERR_VALUE() are incorrect

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.6.0, Lustre 2.5.2
• Affects Version/s: Lustre 2.5.0
• Severity: 3
• Assignee: John Hammond
• Reporter: John Hammond

Description

We have several places in the code that do something equivalent the following

int rc = PTR_ERR(foo);
if (IS_ERR_VALUE(rc))
        bar();

which is wrong.

Issue Links

• is related to: LU-5071 statahead.c:1704:do_statahead_enter()) ASSERTION( lli->u.d.d_sai == ((void *)0) ) failed:

Comments

[Ryan Haasken]

Bobi Jam's version of the b2_5 patch has landed:

http://review.whamcloud.com/#/c/10363/

I will abandon my b2_5 patch here:

http://review.whamcloud.com/#/c/10178/

[Ryan Haasken]

John, the patch for b2_5 looks like it's ready to land.

[Ryan Haasken]

Here is the port to b2_5: http://review.whamcloud.com/#/c/10178/

[Cory Spitz]

As John points out in LU-4985, it would be good to port http://review.whamcloud.com/#/c/6759/ to b2_5.

[Andreas Dilger]

Patch landed to master for 2.6.0.

[John Hammond]

Please see http://review.whamcloud.com/6759.