[LU-3611] Wrong order of locking and allocating memory in mgs_pool_cmd()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.4.1, Lustre 2.5.0
• Affects Version/s: Lustre 2.4.1, Lustre 2.5.0
• Labels: mq313 patch
• Severity: 3
• Assignee: Keith Mannthey (Inactive)
• Reporter: Li Xi (Inactive)

Description

In function mgs_pool_cmd(), fsdb_mutex is locked and then mti is allocated. It is not correct and will cause problem if memory allocating fails and leaves fsdb_mutex locked. Following is the codes.

mutex_lock(&fsdb->fsdb_mutex);

if (canceled_label != NULL)

{ OBD_ALLOC_PTR(mti); if (mti == NULL) GOTO(out_cancel, rc = -ENOMEM); }