Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3808

ptlrpcd_init() returns 0 regardless of errors

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.5.0
    • Lustre 2.5.0
    • 3
    • 9840

    Description

      ptlrpcd_init() returns 0 regardless of errors.

      Attachments

        Activity

          [LU-3808] ptlrpcd_init() returns 0 regardless of errors
          jhammond John Hammond added a comment -

          Patch landed to master.

          jhammond John Hammond added a comment - Patch landed to master.
          spimpale Swapnil Pimpale (Inactive) added a comment -

          Hi,

          I have added a fix for the incorrect return value bug.
          The patch is here --> http://review.whamcloud.com/#/c/7522/

          spimpale Swapnil Pimpale (Inactive) added a comment - Hi, I have added a fix for the incorrect return value bug. The patch is here --> http://review.whamcloud.com/#/c/7522/
          jhammond John Hammond added a comment -

          On this is addressed, there is the issue that ptlrpcd_addref() increments ptlrpc_users regardless of whether ptlrpcd_init() succeeded.

          Also what is the point of calling ptlrpcd_addref() from the obd_setup() methods? ptlrpcd_addref() and hence ptlrpcd_init() is already called from ptlrpc_init(). All of the OBD modules depend on ptlrpc anyway. Is this for liblustre? Can all of theses ptlrcpd_addref() calls just be removed?

          jhammond John Hammond added a comment - On this is addressed, there is the issue that ptlrpcd_addref() increments ptlrpc_users regardless of whether ptlrpcd_init() succeeded. Also what is the point of calling ptlrpcd_addref() from the obd_setup() methods? ptlrpcd_addref() and hence ptlrpcd_init() is already called from ptlrpc_init(). All of the OBD modules depend on ptlrpc anyway. Is this for liblustre? Can all of theses ptlrcpd_addref() calls just be removed?

          People

            jhammond John Hammond
            jhammond John Hammond
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: