[LU-3963] cleanup libcfs wrappers

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.4.0, Lustre 2.5.0
• Labels: emc patch

Epic

client

• Assignee: Nathaniel Clark
• Reporter: Peng Tao

Description

Migrate libcfs to emulate Linux kernel APIs, so that when submitting Linux client to upstream kernel, we don't need the abstraction layer which will be rejected by kernel maintainers. The majority of libcfs are cfs_* or ll_* wrappers, and can be cleaned up with scripts doing like "s/cfs_spin_lock/spin_lock". For other functions that cannot be cleaned up this way, we need to look at them in a case-by-case basis.

Issue Links

• duplicates: LU-1346 cleanup libcfs
• is related to: LU-5018 e2fsprogs build failed
• is related to: LU-2245 failure on sanity.sh test_101c: Small 4k read IO 1!
• is related to: LU-5411 cfs_hlist_for_each_entry() not working as intended
• is related to: LU-8354 soft lockup in ldlm_plain_compat_queue

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13070/
Subject: LU-3963 libcfs: Use kernel's strncasecmp and remove cfs_get_blocked_sigs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d97075bb9644dba102491280690e58ad8caf1acf

[James A Simmons]

Sorry but I included one last patch to complete the SFS-DEV-004 contract. See http://wiki.opensfs.org/index.php?title=Contract_SFS-DEV-004 for details.

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13070
Subject: LU-3963 libcfs: Use kernel's strncasecmp and remove cfs_get_blocked_sigs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1a5bf3003002e317c5e103ad8bb15bf2ab29e030

[James A Simmons]

All the wrappers have been cleaned up. It is best if the phase II work would be done under a new ticket for 2.8. Peter you can close this ticket.

[James A Simmons]

Phase I of this work is complete. No more cfs_list or cfs_atomic etc. Now we are unto phase II which is putting libcfs on a diet. Lots of wrappers still exist that are no longer needed so we will now start that cleanup. First patch for that cleanup is here:

http://review.whamcloud.com/#/c/11963

[James A Simmons]

Last two patches posted have been merged. One last patch for cfs list wrrappers is here:

http://review.whamcloud.com/#/c/11797

[James A Simmons]

http://review.whamcloud.com/#/c/11725 - Empty file removal

http://review.whamcloud.com/#/c/11729 - Removal last of cfs wrappers for SMP handling.

[Jian Yu]

The patches for replacing direct HZ access with Linux kernel APIs will be tracked in LU-5443.

[James A Simmons]

http://review.whamcloud.com/#/c/10387
http://review.whamcloud.com/#/c/10525
http://review.whamcloud.com/#/c/10526

[Nathaniel Clark]

http://review.whamcloud.com/10247