Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3963

cleanup libcfs wrappers

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.7.0
    • Lustre 2.4.0, Lustre 2.5.0
    • 10533

    Description

      Migrate libcfs to emulate Linux kernel APIs, so that when submitting Linux client to upstream kernel, we don't need the abstraction layer which will be rejected by kernel maintainers. The majority of libcfs are cfs_* or ll_* wrappers, and can be cleaned up with scripts doing like "s/cfs_spin_lock/spin_lock". For other functions that cannot be cleaned up this way, we need to look at them in a case-by-case basis.

      Attachments

        Issue Links

          duplicates

          Improvement - An improvement or enhancement to an existing feature or task. LU-1346 cleanup libcfs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-5018 e2fsprogs build failed

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-2245 failure on sanity.sh test_101c: Small 4k read IO 1!

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-5411 cfs_hlist_for_each_entry() not working as intended

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-8354 soft lockup in ldlm_plain_compat_queue

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-3963] cleanup libcfs wrappers
            utopiabound Nathaniel Clark added a comment -

            http://review.whamcloud.com/10247

            utopiabound Nathaniel Clark added a comment - http://review.whamcloud.com/10247
            simmonsja James A Simmons added a comment -

            List cleanup patches:

            http://review.whamcloud.com/#/c/9369
            http://review.whamcloud.com/#/c/9904
            http://review.whamcloud.com/#/c/9944

            simmonsja James A Simmons added a comment - List cleanup patches: http://review.whamcloud.com/#/c/9369 http://review.whamcloud.com/#/c/9904 http://review.whamcloud.com/#/c/9944
            utopiabound Nathaniel Clark added a comment -

            James, Sorry about that.

            utopiabound Nathaniel Clark added a comment - James, Sorry about that.
            simmonsja James A Simmons added a comment -

            Patch 7073 is still outstanding. Also we have the cfs_list to convert. Please reopen this ticket.

            simmonsja James A Simmons added a comment - Patch 7073 is still outstanding. Also we have the cfs_list to convert. Please reopen this ticket.
            utopiabound Nathaniel Clark added a comment -

            Merged to head

            utopiabound Nathaniel Clark added a comment - Merged to head
            simmonsja James A Simmons added a comment -

            Both patches 7072 and 7074 are merged. The patches left to support linux atomics are:

            http://review.whamcloud.com/#/c/7073
            http://review.whamcloud.com/#/c/7077

            simmonsja James A Simmons added a comment - Both patches 7072 and 7074 are merged. The patches left to support linux atomics are: http://review.whamcloud.com/#/c/7073 http://review.whamcloud.com/#/c/7077
            simmonsja James A Simmons added a comment -

            The following Ppatches for atomic conversion are ready for inspection:

            http://review.whamcloud.com/#/c/7072
            http://review.whamcloud.com/#/c/7074

            simmonsja James A Simmons added a comment - The following Ppatches for atomic conversion are ready for inspection: http://review.whamcloud.com/#/c/7072 http://review.whamcloud.com/#/c/7074
            simmonsja James A Simmons added a comment -

            Patches for atomic conversion to linux api.

            http://review.whamcloud.com/#/c/7072
            http://review.whamcloud.com/#/c/7073
            http://review.whamcloud.com/#/c/7074
            http://review.whamcloud.com/#/c/7075
            http://review.whamcloud.com/#/c/7076
            http://review.whamcloud.com/#/c/7077

            simmonsja James A Simmons added a comment - Patches for atomic conversion to linux api. http://review.whamcloud.com/#/c/7072 http://review.whamcloud.com/#/c/7073 http://review.whamcloud.com/#/c/7074 http://review.whamcloud.com/#/c/7075 http://review.whamcloud.com/#/c/7076 http://review.whamcloud.com/#/c/7077
            simmonsja James A Simmons added a comment -

            Here is something strange. Maloo test for http://review.whamcloud.com/#/c/7803 report conf-sanity and sanity as failing but when you examine the logs all the test passed. The link for the maloo test results is https://maloo.whamcloud.com/test_sessions/fa54b9f0-5daa-11e3-a404-52540035b04c

            simmonsja James A Simmons added a comment - Here is something strange. Maloo test for http://review.whamcloud.com/#/c/7803 report conf-sanity and sanity as failing but when you examine the logs all the test passed. The link for the maloo test results is https://maloo.whamcloud.com/test_sessions/fa54b9f0-5daa-11e3-a404-52540035b04c
            simmonsja James A Simmons added a comment -

            http://review.whamcloud.com/#/c/4780 has been updated. The patch now only changes the libcfs core. It also defines linux api's for non-linux systems and still support the current cfs_* wrappers.

            simmonsja James A Simmons added a comment - http://review.whamcloud.com/#/c/4780 has been updated. The patch now only changes the libcfs core. It also defines linux api's for non-linux systems and still support the current cfs_* wrappers.
            adilger Andreas Dilger added a comment -

            It would be great to get the base patch for cfs_list conversion (to rename base cfs_list_* functions and add compat wrappers for other arches) so that new patches that are landing can use the list_* versions and avoid increasing the number of functions that need to be converted.

            adilger Andreas Dilger added a comment - It would be great to get the base patch for cfs_list conversion (to rename base cfs_list_* functions and add compat wrappers for other arches) so that new patches that are landing can use the list_* versions and avoid increasing the number of functions that need to be converted.

            People

              utopiabound Nathaniel Clark
              bergwolf Peng Tao
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: