[LU-5123] lprocfs_write_frac_u64_helper does not respect multiplier

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.6.0
• Affects Version/s: Lustre 2.6.0
• Labels: patch
• Severity: 3
• Assignee: Emoly Liu
• Reporter: Stephen Champion

Description

Working on LU-4856, I have made use of lprocfs_write_frac_u64_helper, which turns out to not work. Specifically, the mult arg is ignored because of this logic:

units = 1;
if (units)
mult = mult < 0 ? -units : units;

This led to sanity 101a setting the 64 bit converted max_cached_mb to 32 pages (not mb) - which hung in a way that may be interesting in it's own right.

Comments

[Peter Jones]

Landed for 2.6

[Peter Jones]

Thanks Steve.

Emoly

Could you please help with this patch?

Thanks

Peter

[Stephen Champion]

http://review.whamcloud.com/#/c/10535/