Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5320

Use after free, double lock found by coccinelle

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.6.0
    • None
    • 3
    • 14857

    Description

      When coccinelle (a static analyser) is run on the Lustre code, with the current Linux kernel scripts, it finds, amongst other things, the following errors:

        
lustre/include/obd_support.h:792:19-22: ERROR: reference preceded by free on line 791
lustre/ptlrpc/nrs_tbf.c:312:2-8: preceding lock on line 307
lustre/fid/fid_handler.c:73:43-51: ERROR: cli is NULL but dereferenced.
lustre/lfsck/lfsck_lib.c:1564:1-10: second lock on line 1571

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-2753 Tracking bug for static code analysis fixes.

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Resolved

          Activity

            [LU-5320] Use after free, double lock found by coccinelle
            emoly.liu Emoly Liu made changes -
            Link New: This issue is related to IEEL-102 [ IEEL-102 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-2753 [ LU-2753 ]
            pjones Peter Jones made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            adilger Andreas Dilger made changes -
            Summary Original: Bug found by coccinelle New: Use after free, double lock found by coccinelle
            jlevi Jodi Levi (Inactive) made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Jodi Levi [ jlevi ]
            jlevi Jodi Levi (Inactive) made changes -
            Priority Original: Minor [ 4 ] New: Critical [ 2 ]
            jlevi Jodi Levi (Inactive) made changes -
            Fix Version/s New: Lustre 2.6.0 [ 10595 ]
            pjones Peter Jones made changes -
            Labels New: patch
            fzago Frank Zago (Inactive) created issue -

            People

              jlevi Jodi Levi (Inactive)
              fzago Frank Zago (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: