[LU-5320] Use after free, double lock found by coccinelle

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.6.0
• Labels: patch
• Severity: 3
• Assignee: Jodi Levi (Inactive)
• Reporter: Frank Zago (Inactive)

Description

When coccinelle (a static analyser) is run on the Lustre code, with the current Linux kernel scripts, it finds, amongst other things, the following errors:

  
lustre/include/obd_support.h:792:19-22: ERROR: reference preceded by free on line 791
lustre/ptlrpc/nrs_tbf.c:312:2-8: preceding lock on line 307
lustre/fid/fid_handler.c:73:43-51: ERROR: cli is NULL but dereferenced.
lustre/lfsck/lfsck_lib.c:1564:1-10: second lock on line 1571

Issue Links

• is related to: LU-2753 Tracking bug for static code analysis fixes.