[LU-5817] cl_put_grouplock()) ASSERTION( cg->cg_gid ) failed

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.7.0, Lustre 2.5.3
• Labels: MB patch
• Environment: Any 2.x version of Lustre. Client crash.
• Severity: 3
• Assignee: Cliff White (Inactive)
• Reporter: Patrick Farrell (Inactive)

Description

When a group lock with GID=0 is released (put_grouplock is called), an assertion in cl_put_grouplock is hit.

There are two assertions at the start of cl_put_grouplock:
LASSERT(cg->cg_env);
LASSERT(cg->cg_gid);

cg_env is a pointer, so this assertion is valid, but cg_gid is just an integer so this is not a valid assertion. There are no other checks to make sure the GID is not zero, so a zero a GID is otherwise valid.

Since there doesn't appear to be any reason a '0' GID shouldn't be allowed, the solution is to remove this assertion. I'll make a patch shortly.

Issue Links

• is duplicated by: LU-5918 (lcommon_misc.c:194:cl_put_grouplock()) ASSERTION( cg->cg_gid ) failed