Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5830

use lustre_rmmod in lnet start/stop script

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.7.0, Lustre 2.5.4
    • Lustre 2.7.0, Lustre 2.5.4
    • None
    • 3
    • 16352

    Description

      When trying to enable and use lnet start/stop script to shutdown a stand-alone Lustre Server it fails with errors during modules unload. This comes from a wrong list/order of modules to be unloaded. It would be safer to use lustre_rmmod to do so instead.
      Master patch is at http://review.whamcloud.com/12513.

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. LU-2669 Init script "lnet stop" fails due to incorrect module list

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-5830] use lustre_rmmod in lnet start/stop script
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12587/
            Subject: LU-5830 scripts: use lustre_rmmod in lnet start/stop script
            Project: fs/lustre-release
            Branch: b2_5
            Current Patch Set:
            Commit: e5966bdbb7c7644cc04580ad6b4a9006def3f758

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12587/ Subject: LU-5830 scripts: use lustre_rmmod in lnet start/stop script Project: fs/lustre-release Branch: b2_5 Current Patch Set: Commit: e5966bdbb7c7644cc04580ad6b4a9006def3f758
            adilger Andreas Dilger added a comment -

            Bruno, have you ever done testing with LNet routing to see if that could cause problems that aren't seen in our regular testing? I can't imagine that this three-step shutdown process was created unless there was a reason to do so.

            adilger Andreas Dilger added a comment - Bruno, have you ever done testing with LNet routing to see if that could cause problems that aren't seen in our regular testing? I can't imagine that this three-step shutdown process was created unless there was a reason to do so.
            bfaccini Bruno Faccini (Inactive) added a comment -

            Andreas, you are right they are very similar, and particularly both tickets reason since they both bring out the same flaw in lnet shutdown script. The main difference comes from the need to strictly follow the 3 steps procedure that you have described, which I have never found to be necessary, but may be I am wrong?
            Also last patch-set of change #5478 for LU-2669 has triggered a lot of tests failures that may be caused by the changes it applies to lustre_rmmod, when my patch has not encountered failures during auto-tests.

            bfaccini Bruno Faccini (Inactive) added a comment - Andreas, you are right they are very similar, and particularly both tickets reason since they both bring out the same flaw in lnet shutdown script. The main difference comes from the need to strictly follow the 3 steps procedure that you have described, which I have never found to be necessary, but may be I am wrong? Also last patch-set of change #5478 for LU-2669 has triggered a lot of tests failures that may be caused by the changes it applies to lustre_rmmod, when my patch has not encountered failures during auto-tests.
            adilger Andreas Dilger added a comment -

            Bruno, I noticed that this patch was very similar to http://review.whamcloud.com/5478 "LU-2669 scripts: Change behavior of lustre_rmmod" but doesn't do quite the same thing. That patch removed the Lustre modules before stopping LNet, then removed the ptlrpc/lnet/libcfs modules afterward.

            Is there still value in the changes to lustre_rmmod that http://review.whamcloud.com/5478 made, or should it be abandoned?

            adilger Andreas Dilger added a comment - Bruno, I noticed that this patch was very similar to http://review.whamcloud.com/5478 " LU-2669 scripts: Change behavior of lustre_rmmod" but doesn't do quite the same thing. That patch removed the Lustre modules before stopping LNet, then removed the ptlrpc/lnet/libcfs modules afterward. Is there still value in the changes to lustre_rmmod that http://review.whamcloud.com/5478 made, or should it be abandoned?
            pjones Peter Jones added a comment -

            Landed for 2.7

            pjones Peter Jones added a comment - Landed for 2.7
            yujian Jian Yu added a comment -

            Here is the back-ported patch for Lustre b2_5 branch: http://review.whamcloud.com/12587

            yujian Jian Yu added a comment - Here is the back-ported patch for Lustre b2_5 branch: http://review.whamcloud.com/12587

            People

              bfaccini Bruno Faccini (Inactive)
              bfaccini Bruno Faccini (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: