Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5837

ll_getparent improvements

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.7.0
    • None
    • 3
    • 16364

    Description

      Reviewers have made several suggestions on LU-3613 which, though not critical, should be addressed for the sake of code quality & efficiency.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-5870 New static analysis issues in llite

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-3613 Get parent_fid + name for an entry

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-5837] ll_getparent improvements
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12527/
            Subject: LU-5837 llite: ll_getparent cleanup
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 188325f9211b6f2b87a04ec1155b005b8af54c2b

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12527/ Subject: LU-5837 llite: ll_getparent cleanup Project: fs/lustre-release Branch: master Current Patch Set: Commit: 188325f9211b6f2b87a04ec1155b005b8af54c2b
            gerrit Gerrit Updater added a comment -

            Henri Doreau (henri.doreau@cea.fr) uploaded a new patch: http://review.whamcloud.com/12527
            Subject: LU-5837 llite: ll_getparent cleanup
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 5
            Commit: 749fec00ae1ca47135b7b5cedaf911b9420c2056

            gerrit Gerrit Updater added a comment - Henri Doreau (henri.doreau@cea.fr) uploaded a new patch: http://review.whamcloud.com/12527 Subject: LU-5837 llite: ll_getparent cleanup Project: fs/lustre-release Branch: master Current Patch Set: 5 Commit: 749fec00ae1ca47135b7b5cedaf911b9420c2056
            hdoreau Henri Doreau (Inactive) added a comment -

            So, I've tried to integrate your patch (see patchset #3). I think it adds some complexity (a third function to maintain, with duplicated logic) without bringing much since it's still required to iterate over the variable records to get the N-th entry. I tend to prefer patchset #2.

            hdoreau Henri Doreau (Inactive) added a comment - So, I've tried to integrate your patch (see patchset #3). I think it adds some complexity (a third function to maintain, with duplicated logic) without bringing much since it's still required to iterate over the variable records to get the N-th entry. I tend to prefer patchset #2.
            fzago Frank Zago (Inactive) added a comment -

            0001-LU-5837-llite-create-linkea_seek_entry-and-use-it-in.patch

            fzago Frank Zago (Inactive) added a comment - 0001- LU-5837 -llite-create-linkea_seek_entry-and-use-it-in.patch
            pjones Peter Jones added a comment -

            John

            Could you please review Henri's latest changes?

            Thanks

            Peter

            pjones Peter Jones added a comment - John Could you please review Henri's latest changes? Thanks Peter
            hdoreau Henri Doreau (Inactive) added a comment -

            Initial comments were made on: http://review.whamcloud.com/7069

            Patch addressing the issues: http://review.whamcloud.com/12527

            hdoreau Henri Doreau (Inactive) added a comment - Initial comments were made on: http://review.whamcloud.com/7069 Patch addressing the issues: http://review.whamcloud.com/12527

            People

              jhammond John Hammond
              hdoreau Henri Doreau (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: