[LU-5973] bad error message in ofd_destroy()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.5.4
• Affects Version/s: Lustre 2.5.3
• Severity: 3
• Assignee: Bob Glossman (Inactive)
• Reporter: Bob Glossman (Inactive)

Description

First noticed when examining error logs for a different problem. The following code fragment prints the wrong value in the error log:

                } else if (lrc != 0) {
                        CERROR("%s: error destroying object "DFID": %d\n",
                               ofd_obd(ofd)->obd_name, PFID(&info->fti_fid),
                               rc);
                        rc = lrc;
                }

It should be printing the lrc, not rc. As is the logged message is not as useful as it could be.

Will enter a patch to correct this.

Issue Links

• is duplicated by: LU-6276 LustreError: error destroying object

Comments

[Peter Jones]

Landed for 2.5.4

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12921/
Subject: LU-5973 ofd: fix bad error message
Project: fs/lustre-release
Branch: b2_5
Current Patch Set:
Commit: cae87fca0a1656487786186e8c96ffdac2e3e45a

[Bob Glossman (Inactive)]

no, the equivalent error message in master is already correct. It's a b2_5 only problem.

[Andreas Dilger]

Does this not affect master?

[Gerrit Updater]

Bob Glossman ([e-mail]) uploaded a new patch: http://review.whamcloud.com/12921
Subject: LU-5973 ofd: fix bad error message
Project: fs/lustre-release
Branch: b2_5
Current Patch Set: 1
Commit: bd94f11f5f34f8da24c0bd3e1bfdcedc13e099f3