Details

    • Technical task
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • None
    • None
    • 17335

    Description

      To remove duplication with newer kernels, including upstream clients, we should remove as much duplication in the fiemap code as possible. It was added in Lustre before it existed in the upstream kernel, and still has some differences that are not landed upstream, so some care is needed.

      Most of ll_fiemap.h could be removed:

      • replace struct ll_user_fiemap with struct fiemap in all code (this is already done via #define in ll_fiemap.h)
      • replace struct ll_fiemap_extent with struct fiemap_extent in all code
      • continue to #define fe_device fe_reserved[0] unless we can get the field assignments changed in upstream
      • remove FIEMAP_EXTENT_* constants, except FIEMAP_EXTENT_NET and FIEMAP_EXTENT_NO_DIRECT
      • remove FIEMAP_FLAG_* except FIEMAP_EXTENT_DEVICE_ORDER

      Attachments

        Issue Links

          Activity

            [LU-6201] remove duplicate fiemap code/defines
            pjones Peter Jones added a comment -

            Landed for 2.8

            pjones Peter Jones added a comment - Landed for 2.8

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13608/
            Subject: LU-6201 llite: remove duplicate fiemap defines
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: c65a2c2a41f4fb9b91f25d4ac073364258691d1b

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13608/ Subject: LU-6201 llite: remove duplicate fiemap defines Project: fs/lustre-release Branch: master Current Patch Set: Commit: c65a2c2a41f4fb9b91f25d4ac073364258691d1b

            Bobi Jam (bobijam@hotmail.com) uploaded a new patch: http://review.whamcloud.com/13608
            Subject: LU-6201 llite: remove duplicate fiemap defines
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: fb0b4029b004354209d1f6c9cc3d80518917b668

            gerrit Gerrit Updater added a comment - Bobi Jam (bobijam@hotmail.com) uploaded a new patch: http://review.whamcloud.com/13608 Subject: LU-6201 llite: remove duplicate fiemap defines Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: fb0b4029b004354209d1f6c9cc3d80518917b668

            People

              bobijam Zhenyu Xu
              adilger Andreas Dilger
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: