[LU-6302] annotations for sparse static analyzer

• Type: Improvement
• Resolution: Fixed
• Priority: Trivial
• Fix Version/s: Lustre 2.8.0
• Affects Version/s: Lustre 2.6.0
• Labels: patch
• Severity: 3
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Andreas Dilger

Description

sparse (git://git.kernel.org/pub/scm/devel/sparse/sparse.git) is a static analyzer used in kernel dev. After installing it, it can easily be used with Lustre:

make C=1

Currently there is about 3900 warnings. Most of it is noise, and a few annotations will silence them. However in that noise, some bugs might be lurking.

Besides finding bugs, it currently tags 1000 functions that can be made static. Once marked static, that will enable the compiler to optimize them more aggressively, which may lead to some minor performance improvements.

So far I've cleared about 1000 of them and found only one bug (strcmp with userspace provided buffer in fld_proc_hash_seq_write) and several unused functions.

Issue Links

• is related to: LU-5396 annotations for sparse static analyzer
• is related to: LU-2753 Tracking bug for static code analysis fixes.
• is related to: LU-6215 Sync Lustre external tree with lustre linux kernel client

Comments

[Peter Jones]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14613/
Subject: LU-6302 lov: copy_to_user uses wrong casting
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 99393dc16a663fcf028b49353333a24f1dd3bb1c

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14613
Subject: LU-6302 lov: copy_to_user uses wrong casting
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: aa04f43716c7ebf86c0866f88de6299ddc0c64f2