Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5396

annotations for sparse static analyzer

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: Lustre 2.6.0
    • Fix Version/s: Lustre 2.7.0
    • Labels:
    • Severity:
      3
    • Rank (Obsolete):
      15020

      Description

      sparse (git://git.kernel.org/pub/scm/devel/sparse/sparse.git) is a static analyzer used in kernel dev. After installing it, it can easily be used with Lustre:

      make C=1
      

      Currently there is about 3900 warnings. Most of it is noise, and a few annotations will silence them. However in that noise, some bugs might be lurking.

      Besides finding bugs, it currently tags 1000 functions that can be made static. Once marked static, that will enable the compiler to optimize them more aggressively, which may lead to some minor performance improvements.

      So far I've cleared about 1000 of them and found only one bug (strcmp with userspace provided buffer in fld_proc_hash_seq_write) and several unused functions.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dmiter Dmitry Eremin (Inactive)
                Reporter:
                fzago Frank Zago
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: