[LU-5396] annotations for sparse static analyzer

• Type: Bug
• Resolution: Fixed
• Priority: Trivial
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.6.0
• Labels: patch
• Severity: 3
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Frank Zago (Inactive)

Description

sparse (git://git.kernel.org/pub/scm/devel/sparse/sparse.git) is a static analyzer used in kernel dev. After installing it, it can easily be used with Lustre:

make C=1

Currently there is about 3900 warnings. Most of it is noise, and a few annotations will silence them. However in that noise, some bugs might be lurking.

Besides finding bugs, it currently tags 1000 functions that can be made static. Once marked static, that will enable the compiler to optimize them more aggressively, which may lead to some minor performance improvements.

So far I've cleared about 1000 of them and found only one bug (strcmp with userspace provided buffer in fld_proc_hash_seq_write) and several unused functions.

Issue Links

• is related to: LU-2753 Tracking bug for static code analysis fixes.
• is related to: LU-6215 Sync Lustre external tree with lustre linux kernel client
• is related to: LU-6302 annotations for sparse static analyzer

Comments

[Andreas Dilger]

Create a new ticket LU-6302 for future sparse patches, close this one for the fixes landed to 2.7.0.

[Frank Zago (Inactive)]

There's more patches to come. There's about 300 warnings left.

[James A Simmons]

Looks like all the patches for this ticket were landed.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12567/
Subject: LU-5396 all: use NULL instead of 0
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e49995acfd026f3ca85d05dc1b91d97a8743fe72

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12223/
Subject: LU-5396 lod: (and mdt, mgs) make some symbols static
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ad1810a2dbea1eed5e8b5feb55bdf915a545feb3

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12206/
Subject: LU-5396 lnet: make some functions static
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 33984c012883a7c714429d2c612cf6dcda191974

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12220/
Subject: LU-5396 obdclass: make some functions static
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e0ece89e1ac014a8443fe95860c4a43b88f16f63

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12222/
Subject: LU-5396 mdc: (and lmv, mgc, osc) make some functions static
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 35fe4c696dd0faadc9405c19c68f0dd56aa5bb01

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12221/
Subject: LU-5396 lov: (and ldlm) make some functions static
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9c6d90191a7d7685d98aee7fb49ff6c23e3956ff

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12219/
Subject: LU-5396 ptlrpc: make some functions static
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d00c924149b5dd042e6fee09ef724013df1b4e14