Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6498

Redundant rc check in ll_setattr_raw

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      It looks like we had a bit of a strange code before SOM removal that is even more redundant now in ll_Setattr_raw:

              rc = ll_md_setattr(dentry, op_data);
              if (rc)
                      GOTO(out, rc);
      
              /* RPC to MDT is sent, cancel data modification flag */
              if (rc == 0 && (op_data->op_bias & MDS_DATA_MODIFIED)) {
                      spin_lock(&lli->lli_lock);
                      lli->lli_flags &= ~LLIF_DATA_MODIFIED;
                      spin_unlock(&lli->lli_lock);
              }
      

      So I guess the rc ==0 part could go easily?

      Attachments

        Activity

          People

            wc-triage WC Triage
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: