[LU-6501] nidstrings always true comparisons

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Labels: patch
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

Running smatch I see these three warnings in recently introduced nidstrings.c:

/home/green/smt/git/lustre-release/lnet/lnet/nidstrings.c:360 libcfs_namenum2netstrfns() warn: always true condition '(nf->nf_type >= 0) => (0-u32max >= 0)'
/home/green/smt/git/lustre-release/lnet/lnet/nidstrings.c:373 libcfs_name2netstrfns() warn: always true condition '(libcfs_netstrfns[i]->nf_type >= 0) => (0-u32max >= 0)'
/home/green/smt/git/lustre-release/lnet/lnet/nidstrings.c:487 libcfs_str2net_internal() warn: always true condition '(nf->nf_type >= 0) => (0-u32max >= 0)'

Issue Links

• is blocked by: LU-6744 conf-sanity test_51:(lov_object.c:945:lov_object_delete()) LBUG
• is related to: LU-6245 Untangle userland and kernel space support for libcfs