[LU-6662] mkfs should allow use of errors=panic

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.8.0
• Affects Version/s: Lustre 2.5.3
• Labels: easy
• Severity: 3
• Assignee: Hongchao Zhang
• Reporter: Mahmoud Hanafi

Description

mkfs.lustre defaults mountoptions to error=mount-ro and doesn't allow error=panic. Changing this using tunefs.lustre also gives warning about 'error=mount-ro' is missing.

Is the use of error=panic discouraged? if so why?

Issue Links

• is related to: LU-6978 mkfs.lustre: LDISKFS-fs (loop0): Unrecognized mount option "force_over_128tb" or missing value
• is related to: LU-6952 Mount options parsing problem
• is related to: LU-6442 mkfs -G <value> parameter is not changed actually and default value is applied

Comments

[Joseph Gmitter (Inactive)]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/15870/
Subject: LU-6662 utils: allow overriding default mountopts
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 927effd2c2374508d904d2022c74574e508c07f1

[Peter Jones]

Thanks Mahmoud but, given that there is a patch that - as far as I understand - you are using we should probably hold this open until that has landed to master

[Mahmoud Hanafi]

This LU can be closed

[Andreas Dilger]

Yes, each subtest should be self-contained.

[Jay Lan (Inactive)]

The conf-sanity.sh in 2.5.3 contains only up to test_77. Is it OK to just pick up test_88 added in #15870?

[Gerrit Updater]

Hongchao Zhang ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15870
Subject: LU-6662 utils: allow overriding default mountopts
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 27bdc3417985dbcbe9790492b60ce0d8141bdbba

[Andreas Dilger]

I don't think errors=panic is discouraged, this is likely just an oversight from the time when the errors=remount-ro option was never being specified and the warning message was added to ensure that this wasn't missed.

To fix this problem, I think the right approach is to change the code to check for any errors= option being specified. However, this is complicated by the way that the code is currently implemented, since for it sets errors=remount-ro into default_mountopts in ldiskfs_prepare_lustre(), and then later checks in check_mountfsoptions() whether those default options are present.

There isn't really an easy way to change this currently, though I think it would be better to change the osd_prepare_lustre() method to be passed only actual mountopts string, ldd_mount_opts[] and its maximum size, instead of passing the default_mountopts and always_mountopts back to the caller. That would allow ldiskfs_prepare_lustre() to verify the mountopts string to handle cases like this, store the defaults into ldd_mount_opts[], and append any user-specified values to override the default values.

[Peter Jones]

Hongchao

Could you please advise on this one?

Thanks

Peter