[LU-7315] In osd_dirent_check_repair(), Pointer 'hlock' can be NULL and can be dereferenced

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.8.0
• Labels: kw
• Severity: 3
• Assignee: nasf (Inactive)
• Reporter: Dmitry Eremin (Inactive)

Description

1. Pointer may be passed to function that can dereference it after it was positively checked for NULL
   • lustre/osd-ldiskfs/osd_handler.c: in osd_dirent_check_repair, Pointer 'hlock' checked for NULL at line 5478 may be passed to function and may be dereferenced there by passing argument 4 to function '__ldiskfs_find_entry' at line 5353. Also there are 2 similar errors on lines 5353.
2. Null pointer may be passed to function that may dereference it
   • lustre/osd-ldiskfs/osd_handler.c: in osd_dirent_check_repair, Null pointer 'hlock' that comes from line 5257 may be passed to function and can be dereferenced there by passing argument 4 to function '__ldiskfs_find_entry' at line 5353.

The list of commits since the previous build 2.7.61-9-g4438262:

723065f	LU-6868 mdd: add changelog for migration
3c86f72	LU-7295 osp: do not warn on uncommitted changes
9ea40a3	LU-6746 ptlrpc: Move IT_* definitions to lustre_idl.h
4691290	LU-6556 obdclass: re-allow catalog to wrap around
ef63c03	LU-4341 test: skip failing sanity test 170
e94d375	LU-7153 build: Update SPL/ZFS to 0.6.5.2
10ebe81	LU-6155 osd-zfs: dbuf_hold_impl() called without the lock
bee9c18	LU-6852 ldlm: Do not evict MDS-MDS connection
cc0733f	LU-6215 lnet: make o2iblnd buildable for 4.2.1 kernels
31b7404	LU-2049 grant: delay grant releasing until commit
dd16884	LU-6204 misc: Add missing MODULE_VERSION for lustre
2907eb6	LU-7244 llite: Fix XATTR_NAME_EVM redefinition
173b332	LU-7122 utils: changelog_ {de} register cleanup
bc17c8d	LU-6899 test: rename sanity test_162 to test_162a
1443374	LU-5733 lnet: Use lnet_is_route_alive for router aliveness
d2d725d	LU-7184 lod: cleanup unused OSP devices on error
d8612e3	LU-6895 scrub: not trigger scrub if inode removed by race
eebc3da	LU-6895 lfsck: not destroy directory when fix FID-in-dirent
5fa93f6	LU-6386 tgt: don't update client data with smaller transno
85c6c09	LU-7045 osd: enough credits for single indirect block write
888a314	LU-6842 clio: add cl_page LRU shrinker
7b56957	LU-7005 tests: wait client imports fully recovered
e72c150	LU-7196 kernel: kernel update RHEL 6.7 [2.6.32-573.7.1.el6]
cbb42d0	LU-6886 mdd: declare changelog store for POSIX ACLs
4d4771b	LU-7074 mdd: validate the linkea before packing
adce06a	LU-7228 build: make lustre rpm also provide lustre-client
9937eb5	LU-7082 test: fix synchronization of conf_sanity test_90
a2844eb	LU-6215 ldlm: handle percpu_counter_init change in 3.18+ kernels
55afbf5	LU-6527 ext4: journal_commit_callback optimization
7f5c975	LU-3322 ko2iblnd: Support different configs between systems
efe3842	LU-6584 osd: prevent int type overflow in osd_read_prep()
881b288	LU-7222 tests: add Mulitple MDTs to test_84
790ca7b	LU-3281 obdclass: remove structure holes to reduce memory
846efa4	LU-7162 kernel: kernel update RHEL 7.1 [3.10.0-229.14.1.el7]
c250f40	Revert "LU-5951 ptlrpc: track unreplied requests"

Issue Links

• is related to: LU-6895 sanity-lfsck test 4 hung: bad entry in directory: rec_len is smaller than minimal - inode=3925999616