[LU-7623] Clean up lustre user/kernel pointer types.

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.8.0, Lustre 2.9.0
• Severity: 3
• Assignee: Oleg Drokin
• Reporter: Oleg Drokin

Description

Currently there's a significant mess in Lustre code in regards to kernel/user pointers.
Structures are not separated and could be used from both which is bad for multiple reasons.
This also makes it hard for various static tools to properly enforce access rules.

Things like IOC_LIBCFS_DEBUG_PEER "ioctl" should be cleaned out and the __user modifiers added all around in the structures to make everything work nice and well.

Issue Links

• is related to: LU-7624 fld_proc_hash_seq_write accesses userspace pointer directly
• is related to: LU-6215 Sync Lustre external tree with lustre linux kernel client

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/18950/
Subject: LU-7623 lnet: remove useless cast
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ba162203853721dd2ad16bcc2212b11461974264

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/18950
Subject: LU-7623 lnet: remove useless cast
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d6a8c4abea6f0c7e5e9d2cb6547cb92319f0e282

[James A Simmons]

All patches have landed.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17789/
Subject: LU-7623 mdt: Match up prototype and definition of mdt_hsm_cdt_control_seq_write
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f5f3725d43b30ea9af3928ebb5bfd6fdc2c5c964

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17784/
Subject: LU-7623 lnet: Properly declare lnet_ping() forward declaration
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 115011c524e8674de010ddd2dea4afb497c1884e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17783/
Subject: LU-7623 lmv: Mark lmv_hsm_ct_register/unregister uarg as __user
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3b2dad4ebb4ac81cebeab6c7e0c4ecb67f1de7ea

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17782/
Subject: LU-7623 lmv: Properly mark lmv_fid2path uarg argment as __user
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bdd1272607a95482d6b5261de7fe8bec1d57e2a8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17781/
Subject: LU-7623 Update obd iocontrol methods with __user attribute
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9175d6f862039cfbf6b85333d72a9d91e64ea42a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17780/
Subject: LU-7623 lov: Get rid of an ugly statfs hack in lov_iocontrol
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9281658095a63c88a12246df5fb6f3b78f97095a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17779/
Subject: LU-7623 lnet: Get rid of IOC_LIBCFS_PORTALS_COMPATIBILITY ioctl
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9bafa64985cae09eee5adaba5725038df1bf12e3