[LU-8006] Specify ordering of TBF policy rules

• Type: Question/Request
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.9.0
• Affects Version/s: Lustre 2.7.0
• Labels: cea patch
• Assignee: Li Xi (Inactive)
• Reporter: Mahmoud Hanafi

Description

In the documentation it states " Whenever a queue is newly created, it goes though the rule list and takes the first matched rule as its rule, so that the queue knows its RPC token rate."

How does it the order the rules? Is it in the order they were created?

We want 2 initial sets of NID groups, 'Login' and 'compute'. But the compute nodes' NIDs are not uniquely different from the login nodes. But if we can order the rules we can list the login nodes first and then compute.

Issue Links

• is related to: LU-14724 Kernel crash when setting NRS TBF policy
• is related to: LU-8008 Can't enable or add rules to TBF
• is related to: LU-3558 NRS TBF policy for QoS purposes
• is related to: LUDOC-328 documentation updates for complex TBF policies
• is related to: LU-5620 nrs tbf policy based on opcode
• is related to: LU-7470 Extend TBF policy with NID/JobID expressions

Comments

[Peter Jones]

Landed for 2.9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/19476/
Subject: LU-8006 ptlrpc: specify ordering of TBF policy rules
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: aa14b0b9a1521b3deb26a07eb8f7bb28ce793001

[Li Xi (Inactive)]

http://review.whamcloud.com/#/c/19476/ still needs review.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/19499/
Subject: LU-8006 ptlrpc: cleanup codes of TBF command
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d09237044382361b289c01a9f7412818b3599e79

[Emoly Liu]

If needed, I can backport these patches to 2.7.1fe after they are landed.

[Mahmoud Hanafi]

we need these for 2.7.1 fe

[Gerrit Updater]

Li Xi ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19499
Subject: LU-8006 ptlrpc: cleanup codes of TBF command
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 59bede110333b39925d9c3f66702859cf2ff00ca

[Gerrit Updater]

Li Xi ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19476
Subject: LU-8006 ptlrpc: interface for changing ranks of TBF rules
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 06ce138bbfc637f48d8e8be61d44798f9383cc6f

[Andreas Dilger]

Currently the order of the TBF rules is the order in which they are created. I've recently discussed this with Li Xi that along with the change to allow complex TBF policies that specify combinations of NID, RPC opcode, JobID, UID/GID, etc, there needs to be a way to insert/delete rules in arbitrary order, as tools like iptables allow.