[LU-8036] lustreapi.h should not define ARRAY_SIZE()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Affects Version/s: Lustre 2.9.0
• Labels: easy llapi tech-debt
• Severity: 3
• Assignee: John Hammond
• Reporter: John Hammond

Description

After http://review.whamcloud.com/#/c/10029/ LU-4931 ladvise: Add feature of giving file access advices, lustreapi.h unconditionally defines an ARRAY_SIZE() macro. This is inappropriate for lustreapi.h and may cause unexpected compilation failures when lustreapi.h is used out of tree (or perhaps even in tree). Instead we should do

#ifndef ARRAY_SIZE
# define ARRAY_SIZE(a) ...
#endif

(after all headers have been included) in lustre/utils/lfs.c and lustre/utils/req-layout.c.

Comments

[Joseph Gmitter (Inactive)]

patch has landed to master for 2.9.0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/19818/
Subject: LU-8036 utils: remove ARRAY_SIZE() define from lustreapi.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0efd46fd2e685790b49815007dac4484da73f136

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19818
Subject: LU-8036 utils: remove ARRAY_SIZE() define from lustreapi.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6a0110e2b7207af62b94e0882088d56c509065cc