Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8499

wireshark plugins don't build any more

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.9.0
    • Lustre 2.9.0
    • None
    • 3
    • 9223372036854775807

    Description

      Patch e14246641c04c9e3004043f58f469532223d06d6 added some code to the wireshark plugin to handle the new ladvise feature, but the changes appear to have broken the wireshark build.

      On a side note, would it be possible to add a wireshark compile to the jenkins build so that there is coverage?

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-6353 Push Wireshark Support Upstream

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-6671 Wireshark: LDLM_ENQUEUE reply with undecoded buffer

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-8499] wireshark plugins don't build any more
            pjones Peter Jones added a comment -

            Landed for 2.9

            pjones Peter Jones added a comment - Landed for 2.9
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22074/
            Subject: LU-8499 wireshark: fix packet-lustre so it compiles
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: a653adc01d71f890d1b2b6549f34afb409485bf5

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/22074/ Subject: LU-8499 wireshark: fix packet-lustre so it compiles Project: fs/lustre-release Branch: master Current Patch Set: Commit: a653adc01d71f890d1b2b6549f34afb409485bf5
            gerrit Gerrit Updater added a comment -

            Kit Westneat (kit.westneat@gmail.com) uploaded a new patch: http://review.whamcloud.com/22074
            Subject: LU-8499 wireshark: fix packet-lustre so it compiles
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: acfc80ce207215d1c4252995085fa8d35accd6ee

            gerrit Gerrit Updater added a comment - Kit Westneat (kit.westneat@gmail.com) uploaded a new patch: http://review.whamcloud.com/22074 Subject: LU-8499 wireshark: fix packet-lustre so it compiles Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: acfc80ce207215d1c4252995085fa8d35accd6ee
            adilger Andreas Dilger added a comment -

            Kit, can you please provide more detail of what problem you are seeing, and ideally a minimal fix to land to master in advance of the larger IU changes.

            That said, even if IU is sending the updated wireshark plugin to the upstream wireshark maintainers, it would still be a good idea to also land those changes to the Lustre tree so that the updated dissector is available for anyone not using the latest wireshark, or in case it isn't merged upstream promptly.

            adilger Andreas Dilger added a comment - Kit, can you please provide more detail of what problem you are seeing, and ideally a minimal fix to land to master in advance of the larger IU changes. That said, even if IU is sending the updated wireshark plugin to the upstream wireshark maintainers, it would still be a good idea to also land those changes to the Lustre tree so that the updated dissector is available for anyone not using the latest wireshark, or in case it isn't merged upstream promptly.
            adilger Andreas Dilger added a comment -

            Doug, IU is currently working to update the wireshark dissectors for the Shared Secret Key feature, and I've asked them to submit the code upstream to the wireshark project. Even if the upstream code is a bit harder to update when changes are made in Lustre, the truth is that the wireshark code was never really kept up-to-date even when it was part of the Lustre tree. At least this way anyone using wireshark will get reasonably good Lustre decoding out of the box without having to patch and compile it themselves, and it probably won't be significantly more outdated than what is in the tree today.

            Kit, it probably makes sense for you to use the IU version of the wireshark plugin.

            adilger Andreas Dilger added a comment - Doug, IU is currently working to update the wireshark dissectors for the Shared Secret Key feature, and I've asked them to submit the code upstream to the wireshark project. Even if the upstream code is a bit harder to update when changes are made in Lustre, the truth is that the wireshark code was never really kept up-to-date even when it was part of the Lustre tree. At least this way anyone using wireshark will get reasonably good Lustre decoding out of the box without having to patch and compile it themselves, and it probably won't be significantly more outdated than what is in the tree today. Kit, it probably makes sense for you to use the IU version of the wireshark plugin.
            doug Doug Oucharek (Inactive) added a comment -

            It would be better if our dissectors were pushed upstream to the Wireshark repo so it can evolve independently of Lustre.

            doug Doug Oucharek (Inactive) added a comment - It would be better if our dissectors were pushed upstream to the Wireshark repo so it can evolve independently of Lustre.

            People

              kit.westneat Kit Westneat (Inactive)
              kit.westneat Kit Westneat (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: