Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8672

missing error handling in replay-single test_89

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.11.0
    • None
    • 3
    • 9223372036854775807

    Description

      replay-single test_89() does not error out on wait_mds_ost_sync and
      wait_delete_completed timeout and error handling in wait_delete_completed_mds and wait_delete_completed in t-f needs correction.

      wait_delete_complete() depends on the return code from wait_delete_completed_mds(), however wait_delete_completed_mds() does not return error code (non-zero) in case it could not wait until delete to be completed for some reason. This could mislead to test failure of mismatched block and suppress actual root cause.

      wait_delete_completed() {
          wait_delete_completed_mds $1 || return $?      <<<<< problem: wait_delete_completed does not actually return error code
          wait_destroy_complete
      }
      

      Ideally we need to know if wait_delete_completed_mds() failed.

      Attachments

        Issue Links

          Activity

            [LU-8672] missing error handling in replay-single test_89
            pjones Peter Jones added a comment -

            Landed for 2.11

            pjones Peter Jones added a comment - Landed for 2.11

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/22974/
            Subject: LU-8672 tests: Fix error handling in replay-single test_89
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 5446b9b6246c9721394ab3aefb94779c899927de

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/22974/ Subject: LU-8672 tests: Fix error handling in replay-single test_89 Project: fs/lustre-release Branch: master Current Patch Set: Commit: 5446b9b6246c9721394ab3aefb94779c899927de

            Unfortunately, this patch did not fix the replay-single test 20b failure because this patch hit that failure. See https://testing.hpdd.intel.com/test_sets/bbe57164-f9e6-11e7-bd00-52540065bddc

            jamesanunez James Nunez (Inactive) added a comment - Unfortunately, this patch did not fix the replay-single test 20b failure because this patch hit that failure. See https://testing.hpdd.intel.com/test_sets/bbe57164-f9e6-11e7-bd00-52540065bddc

            This may also help to fix intermittent failures in replay-single test_20b reported in LU-10052.

            adilger Andreas Dilger added a comment - This may also help to fix intermittent failures in replay-single test_20b reported in LU-10052 .

            Ashish Purkar (ashish.purkar@seagate.com) uploaded a new patch: http://review.whamcloud.com/22974
            Subject: LU-8672 tests: Fix error handling in replay-single test_89
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 96adde3a35827e4d9dac6c2eedf239a67446fb55

            gerrit Gerrit Updater added a comment - Ashish Purkar (ashish.purkar@seagate.com) uploaded a new patch: http://review.whamcloud.com/22974 Subject: LU-8672 tests: Fix error handling in replay-single test_89 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 96adde3a35827e4d9dac6c2eedf239a67446fb55

            People

              jamesanunez James Nunez (Inactive)
              maximus Ashish Purkar (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: