Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9995

lbuild error: 'LMV_HASH_FLAG_DEAD' undeclared (first use in this function)

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Lustre 2.11.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      The latest lustre code (New tag 2.10.53) commit 57fccbb3 is causing the following lbuild error:
      https://build.hpdd.intel.com/job/lustre-reviews/50400/arch=x86_64,build_type=server,distro=el7,ib_stack=inkernel/console

      /tmp/rpmbuild-lustre-buildbot-Wi8EL9Vz/BUILD/lustre-2.10.53_1_g63b8101/lustre/lfsck/lfsck_striped_dir.c: In function 'lfsck_read_stripe_lmv':
      /tmp/rpmbuild-lustre-buildbot-Wi8EL9Vz/BUILD/lustre-2.10.53_1_g63b8101/lustre/lfsck/lfsck_striped_dir.c:855: error: 'LMV_HASH_FLAG_DEAD' undeclared (first use in this function)
      /tmp/rpmbuild-lustre-buildbot-Wi8EL9Vz/BUILD/lustre-2.10.53_1_g63b8101/lustre/lfsck/lfsck_striped_dir.c:855: error: (Each undeclared identifier is reported only once
      /tmp/rpmbuild-lustre-buildbot-Wi8EL9Vz/BUILD/lustre-2.10.53_1_g63b8101/lustre/lfsck/lfsck_striped_dir.c:855: error: for each function it appears in.)
      
      

      Seems related to this definition:

      #if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 10, 53, 0)
      /* Since lustre 2.8, this flag will not be needed, instead this DEAD
       * and orphan flags will be stored in LMA (see LMAI_ORPHAN)     
       * Keep this flag just for LFSCK, because it still might meet such
        flag when it checks the old FS /
      #define LMV_HASH_FLAG_DEAD      0x40000000 
      #endif
      
      

      Attachments

        Activity

          [LU-9995] lbuild error: 'LMV_HASH_FLAG_DEAD' undeclared (first use in this function)

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/29130/
          Subject: LU-9995 lfsck: keep the LMV_HASH_FLAG_DEAD flag
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 51f4abfa40c0f47453a592a92185c17daae87bd8

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/29130/ Subject: LU-9995 lfsck: keep the LMV_HASH_FLAG_DEAD flag Project: fs/lustre-release Branch: master Current Patch Set: Commit: 51f4abfa40c0f47453a592a92185c17daae87bd8

          Fan Yong (fan.yong@intel.com) uploaded a new patch: https://review.whamcloud.com/29130
          Subject: LU-9995 lfsck: keep the LMV_HASH_FLAG_DEAD flag
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 527b9edd6b043778a3c586ee10d5cc0e71cf93ca

          gerrit Gerrit Updater added a comment - Fan Yong (fan.yong@intel.com) uploaded a new patch: https://review.whamcloud.com/29130 Subject: LU-9995 lfsck: keep the LMV_HASH_FLAG_DEAD flag Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 527b9edd6b043778a3c586ee10d5cc0e71cf93ca
          pjones Peter Jones added a comment -

          Agreed. Fan Yong could you please advise on this?

          pjones Peter Jones added a comment - Agreed. Fan Yong could you please advise on this?
          green Oleg Drokin added a comment -

          I pushed the check to take effect in 2.10.56, but we need to fix it by then.

          I guess Fan Yong would be a good person to loook at this since the only remaining users are in lfsck?

          green Oleg Drokin added a comment - I pushed the check to take effect in 2.10.56, but we need to fix it by then. I guess Fan Yong would be a good person to loook at this since the only remaining users are in lfsck?

          People

            yong.fan nasf (Inactive)
            emoly.liu Emoly Liu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: