Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-11755

Remove redundant LASSERT() in ns_is_{client,server}()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: Lustre 2.11.0
    • Fix Version/s: Lustre 2.13.0, Lustre 2.12.3
    • Labels:
    • Severity:
      3
    • Rank (Obsolete):
      9223372036854775807

      Description

      In ns_is_{client,server}(), (ns->ns_client == LDLM_NAMESPACE_CLIENT || ns->ns_client == LDLM_NAMESPACE_SERVER) implies that (!(ns->ns_client & ~(LDLM_NAMESPACE_CLIENT |
      LDLM_NAMESPACE_SERVER))) is also true, so the latter LASSERT() could be removed from ns_is_{client,server}().

       

      This might be an inconsequential issue. I have not checked if gcc optimizes-out one of the LASSERT()s.

        Attachments

          Activity

            People

            • Assignee:
              nangelinas Nikitas Angelinas
              Reporter:
              nangelinas Nikitas Angelinas
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: