[LU-11755] Remove redundant LASSERT() in ns_is_{client,server}()

• Type: Bug
• Resolution: Fixed
• Priority: Trivial
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.3
• Affects Version/s: Lustre 2.11.0
• Labels: patch
• Severity: 3
• Assignee: Nikitas Angelinas
• Reporter: Nikitas Angelinas

Description

In ns_is_{client,server}(), (ns->ns_client == LDLM_NAMESPACE_CLIENT || ns->ns_client == LDLM_NAMESPACE_SERVER) implies that (!(ns->ns_client & ~(LDLM_NAMESPACE_CLIENT |
LDLM_NAMESPACE_SERVER))) is also true, so the latter LASSERT() could be removed from ns_is_{client,server}().

 

This might be an inconsequential issue. I have not checked if gcc optimizes-out one of the LASSERT()s.