Details
-
Bug
-
Resolution: Fixed
-
Minor
-
Lustre 2.14.0
-
3
-
9223372036854775807
Description
libcfs has wrappers in order to be able to use adler32 as any other crypto module. But libcfs should not be considered as the owner of this implementation.
While this patch is much simpler and works around the issue, I would argue that it's incorrect. I can see no use of a hash algorithm in the kernel who implements the functionality but pretends it does not own the algorithm. Even though these are CRC's using the crypto hash APIs, is there a belief that at some point when Lustre is attempted to be upstreamed this would be accepted? I can't imagine this being accepted as is, but I'm by no means an expert.