Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-13355

adler32 wrapper in libcfs

Details

    • 3
    • 9223372036854775807

    Description

      libcfs has wrappers in order to be able to use adler32 as any other crypto module. But libcfs should not be considered as the owner of this implementation.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-14673 panic: crc32-table: crc32 alg self test failed in fips mode!

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-12475 Lustre file system is causing kernel panic issue when using with fips enabled kernel

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-13355] adler32 wrapper in libcfs
            jfilizetti Jeremy Filizetti added a comment -

            While this patch is much simpler and works around the issue, I would argue that it's incorrect.  I can see no use of a hash algorithm in the kernel who implements the functionality but pretends it does not own the algorithm.  Even though these are CRC's using the crypto hash APIs, is there a belief that at some point when Lustre is attempted to be upstreamed this would be accepted?  I can't imagine this being accepted as is, but I'm by no means an expert.

             

            jfilizetti Jeremy Filizetti added a comment - While this patch is much simpler and works around the issue, I would argue that it's incorrect.  I can see no use of a hash algorithm in the kernel who implements the functionality but pretends it does not own the algorithm.  Even though these are CRC's using the crypto hash APIs, is there a belief that at some point when Lustre is attempted to be upstreamed this would be accepted?  I can't imagine this being accepted as is, but I'm by no means an expert.  
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38205/
            Subject: LU-13355 crypto: crypto engine wrappers in libcfs
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set:
            Commit: 2c92892020567f33bbe59962a4971055786a4d4c

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38205/ Subject: LU-13355 crypto: crypto engine wrappers in libcfs Project: fs/lustre-release Branch: b2_12 Current Patch Set: Commit: 2c92892020567f33bbe59962a4971055786a4d4c
            gerrit Gerrit Updater added a comment -

            Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/38205
            Subject: LU-13355 crypto: crypto engine wrappers in libcfs
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: b82584d1d230c227e466480f340631edeeefbfb0

            gerrit Gerrit Updater added a comment - Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/38205 Subject: LU-13355 crypto: crypto engine wrappers in libcfs Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: b82584d1d230c227e466480f340631edeeefbfb0
            gerrit Gerrit Updater added a comment - - edited

            Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/38204
            Subject: LU-13355 crypto: crypto engine wrappers in libcfs
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 2af1ac528556355fef5ee5f40fd1ce33f766919d

            gerrit Gerrit Updater added a comment - - edited Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/38204 Subject: LU-13355 crypto: crypto engine wrappers in libcfs Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 2af1ac528556355fef5ee5f40fd1ce33f766919d
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37878/
            Subject: LU-13355 crypto: adler32 wrapper in libcfs
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: c7c83582aeee6f8bc54915cce6d64d3307bf1ff6

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37878/ Subject: LU-13355 crypto: adler32 wrapper in libcfs Project: fs/lustre-release Branch: master Current Patch Set: Commit: c7c83582aeee6f8bc54915cce6d64d3307bf1ff6
            gerrit Gerrit Updater added a comment -

            Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/37878
            Subject: LU-13355 crypto: adler32 wrapper in libcfs
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: c125678adde7b3834628d800bed5efb1ef6976b1

            gerrit Gerrit Updater added a comment - Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/37878 Subject: LU-13355 crypto: adler32 wrapper in libcfs Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: c125678adde7b3834628d800bed5efb1ef6976b1

            People

              sebastien Sebastien Buisson
              sebastien Sebastien Buisson
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: