[LU-16661] recommend bash-completion for packages - Whamcloud Community JIRA

Details

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: Lustre 2.16.0
Affects Version/s: None
Labels:
None

Rank (Obsolete):
9223372036854775807

Description

It would be good to add a "Recommends" or "Suggests" bash-completion to the lustre-client-utils and lustre-server-utils .deb packages (and also .rpm packages if that functionality exists today).

The "lctl get_param" command greatly benefits from having bash-completion to provide parameter names, and the other "lctl" and "lfs" commands like "lfs find" and also have completions for many of options, added in ~~LU-12734~~ and ~~LU-13225~~.

I don't want to Depend or Require that package, but it should be installed when possible. I was recently debugging on a client node that didn't have bash-completion installed, and it was more painful than I would like, so regular users should also benefit from these improvements.

Attachments

Issue Links

is related to

LU-13204 sanity test 100: netstat: command not found on SLES15 SP1

Resolved

LU-17018 Unable to install DKMS on Ubuntu client

Resolved

is related to

LU-16382 Make lustre.spec more compliant with SUSE OBS requirements

Resolved

Activity

[LU-16661] recommend bash-completion for packages

Gerrit Updater added a comment - 13/Sep/23 4:07 AM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52281/
Subject: ~~LU-16661~~ build: remove -dev packages for Debian
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c1ebcb0fae24c8238eb89ce06ebe9afb9e4ebe39

Gerrit Updater added a comment - 13/Sep/23 4:07 AM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52281/ Subject: LU-16661 build: remove -dev packages for Debian Project: fs/lustre-release Branch: master Current Patch Set: Commit: c1ebcb0fae24c8238eb89ce06ebe9afb9e4ebe39

Gerrit Updater added a comment - 13/Sep/23 4:07 AM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52225/
Subject: ~~LU-16661~~ build: use "Recommends: perl" for lustre-iokit
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a786db83dd06ad6754989ef7cdf5d79e488050b1

Gerrit Updater added a comment - 13/Sep/23 4:07 AM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52225/ Subject: LU-16661 build: use "Recommends: perl" for lustre-iokit Project: fs/lustre-release Branch: master Current Patch Set: Commit: a786db83dd06ad6754989ef7cdf5d79e488050b1

Gerrit Updater added a comment - 05/Sep/23 8:35 PM

"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52281
Subject: ~~LU-16661~~ build: remove -dev packages for Debian
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fb7e36b2f45d5f0f903870fb8e2dcff8ad6383b3

Gerrit Updater added a comment - 05/Sep/23 8:35 PM "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52281 Subject: LU-16661 build: remove -dev packages for Debian Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: fb7e36b2f45d5f0f903870fb8e2dcff8ad6383b3

Gerrit Updater added a comment - 01/Sep/23 9:23 PM

"Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52225
Subject: ~~LU-16661~~ build: use "Recommends: perl" for lustre-iokit
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 211d983c9e6cdd4510d8caf7cc045414f57717a1

Gerrit Updater added a comment - 01/Sep/23 9:23 PM "Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52225 Subject: LU-16661 build: use "Recommends: perl" for lustre-iokit Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 211d983c9e6cdd4510d8caf7cc045414f57717a1

Raphael Druon added a comment - 07/Aug/23 7:31 AM

Thanks, I opened https://jira.whamcloud.com/browse/LU-17018

Raphael Druon added a comment - 07/Aug/23 7:31 AM Thanks, I opened https://jira.whamcloud.com/browse/LU-17018

Andreas Dilger added a comment - 06/Aug/23 7:10 AM

Raphael, probably best if you just submitted a patch directly, since you are in the best place to do it correctly and test it...

Andreas Dilger added a comment - 06/Aug/23 7:10 AM Raphael, probably best if you just submitted a patch directly, since you are in the best place to do it correctly and test it...

Raphael Druon added a comment - 04/Aug/23 10:07 AM

This is causing issue with Ubuntu as it doesn't have the "linux-image" package installed but the "linux-image-generic" one.

"linux-image-*-generic" does provide the "linux-image" package:

root@co-es-pm-140:~/exa-client# dpkg -s linux-image-5.15.0-78-generic
Package: linux-image-5.15.0-78-generic
Status: install ok installed
Priority: optional
Section: kernel
Installed-Size: 11348
Maintainer: Canonical Kernel Team <kernel-team@lists.ubuntu.com>
Architecture: amd64
Source: linux-signed
Version: 5.15.0-78.85
Provides: fuse-module, ivtv-modules, kvm-api-4, linux-image, redhat-cluster-modules, spl-dkms, spl-modules, v4l2loopback-dkms, v4l2loopback-modules, virtualbox-guest-modules, zfs-dkms, zfs-modules
Depends: kmod, linux-base (>= 4.5ubuntu1~16.04.1), linux-modules-5.15.0-78-generic
Recommends: grub-pc | grub-efi-amd64 | grub-efi-ia32 | grub | lilo, initramfs-tools | linux-initramfs-tool
Suggests: fdutils, linux-doc | linux-source-5.15.0, linux-tools, linux-headers-5.15.0-78-generic, linux-modules-extra-5.15.0-78-generic
Conflicts: linux-image-unsigned-5.15.0-78-generic
Description: Signed kernel image generic
 A kernel image for generic.  This version of it is signed with
 Canonical's signing key.
Built-Using: linux (= 5.15.0-78.85)

But this field is ignored when "Depends" is versioned as stated in the Debian policy manual

If the Provides field does not specify a version number, it will not satisfy versioned dependencies or violate versioned Conflicts or Breaks.

Could we add the "linux-image-generic" package in the dkms dependency in addition to the existing "linux-image*" one in "debian/control"?

Raphael Druon added a comment - 04/Aug/23 10:07 AM This is causing issue with Ubuntu as it doesn't have the "linux-image" package installed but the "linux-image-generic" one. "linux-image-*-generic" does provide the "linux-image" package: root@co-es-pm-140:~/exa-client# dpkg -s linux-image-5.15.0-78- generic Package: linux-image-5.15.0-78- generic Status: install ok installed Priority: optional Section: kernel Installed-Size: 11348 Maintainer: Canonical Kernel Team <kernel-team@lists.ubuntu.com> Architecture: amd64 Source: linux-signed Version: 5.15.0-78.85 Provides: fuse-module, ivtv-modules, kvm-api-4, linux-image, redhat-cluster-modules, spl-dkms, spl-modules, v4l2loopback-dkms, v4l2loopback-modules, virtualbox-guest-modules, zfs-dkms, zfs-modules Depends: kmod, linux-base (>= 4.5ubuntu1~16.04.1), linux-modules-5.15.0-78- generic Recommends: grub-pc | grub-efi-amd64 | grub-efi-ia32 | grub | lilo, initramfs-tools | linux-initramfs-tool Suggests: fdutils, linux-doc | linux-source-5.15.0, linux-tools, linux-headers-5.15.0-78- generic , linux-modules-extra-5.15.0-78- generic Conflicts: linux-image-unsigned-5.15.0-78- generic Description: Signed kernel image generic A kernel image for generic . This version of it is signed with Canonical's signing key. Built-Using: linux (= 5.15.0-78.85) But this field is ignored when "Depends" is versioned as stated in the Debian policy manual If the Provides field does not specify a version number, it will not satisfy versioned dependencies or violate versioned Conflicts or Breaks . Could we add the "linux-image-generic" package in the dkms dependency in addition to the existing "linux-image*" one in "debian/control"?

Peter Jones added a comment - 26/Apr/23 1:30 PM

Landed for 2.16

Peter Jones added a comment - 26/Apr/23 1:30 PM Landed for 2.16

Gerrit Updater added a comment - 26/Apr/23 6:27 AM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50397/
Subject: ~~LU-16661~~ build: improve lustre.spec.in Requires
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 621e0bc2f9d4e7d9aed0ec14e939eae4451a8f1e

Gerrit Updater added a comment - 26/Apr/23 6:27 AM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50397/ Subject: LU-16661 build: improve lustre.spec.in Requires Project: fs/lustre-release Branch: master Current Patch Set: Commit: 621e0bc2f9d4e7d9aed0ec14e939eae4451a8f1e

Gerrit Updater added a comment - 04/Apr/23 2:38 PM

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50396/
Subject: ~~LU-16661~~ build: add Recommends and Suggests for Debian
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 73ed44854a740b78523ed1f050960038c8adf552

Gerrit Updater added a comment - 04/Apr/23 2:38 PM "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50396/ Subject: LU-16661 build: add Recommends and Suggests for Debian Project: fs/lustre-release Branch: master Current Patch Set: Commit: 73ed44854a740b78523ed1f050960038c8adf552

People

Assignee:: Andreas Dilger

Reporter:: Andreas Dilger

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 23/Mar/23 11:13 PM

Updated:: 13/Sep/23 4:07 AM

Resolved:: 26/Apr/23 1:30 PM