Details

    • Bug
    • Resolution: Duplicate
    • Minor
    • None
    • None
    • 2
    • 6322

    Description

      Compilation with --disable-liblustre is broken. According to git bisect, the regression was introduced by commit bfb38a047e0fc12e68a7aa3a2d2ec7a6e9d696ed.

      The patch attached, generated against master, seems to fix the issue.

      Attachments

        Activity

          [LU-1965] Lustre --disable-liblustre broken

          The fix from LU-1905 works like a charm.
          Sorry for the noise!

          hdoreau Henri Doreau (Inactive) added a comment - The fix from LU-1905 works like a charm. Sorry for the noise!
          pjones Peter Jones added a comment -

          The fix from LU-1905 has now been landed to master. Please speak up if the problem still remains now.

          pjones Peter Jones added a comment - The fix from LU-1905 has now been landed to master. Please speak up if the problem still remains now.

          This is already being fixed in LU-1905, though it seems that patch hasn't landed yet. A comment in the patch (http://review.whamcloud.com/3953) should help it move along, which I would do now except I'm travelling.

          LU-1905 build: Always create libcfs.a

          Lustre and LNET utilites have become dependent on libcfs.a but
          one can easily disable libcfs.a from being built by disabling
          liblustre creation. This patch have Lustre always build libcfs.a.

          Signed-off-by: James Simmons <uja.ornl@gmail.com>
          Change-Id: Id80f9baa16da238eca708409e0b5d5248e437c5a

          Cheers, Andreas

          Andreas Dilger Whamcloud, Inc.
          Principal Lustre Engineer http://www.whamcloud.com/

          adilger Andreas Dilger added a comment - This is already being fixed in LU-1905 , though it seems that patch hasn't landed yet. A comment in the patch ( http://review.whamcloud.com/3953 ) should help it move along, which I would do now except I'm travelling. LU-1905 build: Always create libcfs.a Lustre and LNET utilites have become dependent on libcfs.a but one can easily disable libcfs.a from being built by disabling liblustre creation. This patch have Lustre always build libcfs.a. Signed-off-by: James Simmons <uja.ornl@gmail.com> Change-Id: Id80f9baa16da238eca708409e0b5d5248e437c5a Cheers, Andreas – Andreas Dilger Whamcloud, Inc. Principal Lustre Engineer http://www.whamcloud.com/

          I think there is already a patch for this, but I can't search for it right now on my phone.

          adilger Andreas Dilger added a comment - I think there is already a patch for this, but I can't search for it right now on my phone.
          pjones Peter Jones added a comment -

          Yes - thanks Henri!

          pjones Peter Jones added a comment - Yes - thanks Henri!

          Peter,

          thanks, I've pushed my changes to Gerrit. Please let me know if not everything is in order.

          http://review.whamcloud.com/#change,4010

          hdoreau Henri Doreau (Inactive) added a comment - Peter, thanks, I've pushed my changes to Gerrit. Please let me know if not everything is in order. http://review.whamcloud.com/#change,4010
          pjones Peter Jones added a comment -

          Henri

          Thanks for the patch. Could you please upload the patch into gerrit so that we can review/test/land it? There are instructions relating to this on the Whamcloud wiki and your colleagues should be able to provide guidance on how to set this up if you need it.

          Minh

          Could you please take care of landing this fix once it is available in gerrit?

          Thanks

          Peter

          pjones Peter Jones added a comment - Henri Thanks for the patch. Could you please upload the patch into gerrit so that we can review/test/land it? There are instructions relating to this on the Whamcloud wiki and your colleagues should be able to provide guidance on how to set this up if you need it. Minh Could you please take care of landing this fix once it is available in gerrit? Thanks Peter

          People

            mdiep Minh Diep
            hdoreau Henri Doreau (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: