[LU-2217] Fix 'NULL pointer dereference' errors

• Type: Technical task
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.5.0
• Affects Version/s: Lustre 2.4.0, Lustre 2.1.3
• Labels: build coverity patch
• Assignee: Emoly Liu
• Reporter: Sebastien Buisson (Inactive)

Description

Thanks to the Coverity tool, we found some Null pointer dereferences in the Lustre code.

I will propose a patch to address the issues.

Comments

[Peter Jones]

Landed for 2.5

[Sebastien Buisson (Inactive)]

Hi,

After reviews, I removed unnecessary assertions from the patches. As the resulting patches are a lot smaller, I reintegrated all the modifications into a single patch, pushed here:
http://review.whamcloud.com/4720

The other patches are abandoned.

Sebastien.

[Emoly Liu]

Oleg,

As Keith mentioned, these patches are a great many LASSERT adds, something like LU-1961, so could you please take a look at them?

Thanks,
Emoly

[Sebastien Buisson (Inactive)]

The big patch proposed initially has been split into four smaller ones:
http://review.whamcloud.com/4720
http://review.whamcloud.com/4721
http://review.whamcloud.com/4722
http://review.whamcloud.com/4723

[Emoly Liu]

The patch has been reviewed. Since the new assetion in mdt_open.c caused recovery-small.sh test_23 and replay-single.sh test_14 failure, the patch needs to be revised further.

[Emoly Liu]

Sorry for my late reply. I am still relative new for jira.
I will review this patch soon.

Emoly

[Peter Jones]

Thanks for the patch Sebastien.

Emoly

Could you please help by reviewing Sebastien's suggested patch?

Thanks

Peter

[Sebastien Buisson (Inactive)]

The patch is available here:

http://review.whamcloud.com/4369

It implements a defensive approach in some parts of the code, adding many LASSERT() calls.

Thanks,
Sebastien.