Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-2753 Tracking bug for static code analysis fixes.
  3. LU-2217

Fix 'NULL pointer dereference' errors

Details

    • Technical task
    • Resolution: Fixed
    • Major
    • Lustre 2.5.0
    • Lustre 2.4.0, Lustre 2.1.3
    • 5275

    Description

      Thanks to the Coverity tool, we found some Null pointer dereferences in the Lustre code.

      I will propose a patch to address the issues.

      Attachments

        Activity

          [LU-2217] Fix 'NULL pointer dereference' errors
          pjones Peter Jones made changes -
          Fix Version/s New: Lustre 2.5.0 [ 10295 ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          pjones Peter Jones added a comment -

          Landed for 2.5

          pjones Peter Jones added a comment - Landed for 2.5
          sebastien.buisson Sebastien Buisson (Inactive) added a comment -

          Hi,

          After reviews, I removed unnecessary assertions from the patches. As the resulting patches are a lot smaller, I reintegrated all the modifications into a single patch, pushed here:
          http://review.whamcloud.com/4720

          The other patches are abandoned.

          Sebastien.

          sebastien.buisson Sebastien Buisson (Inactive) added a comment - Hi, After reviews, I removed unnecessary assertions from the patches. As the resulting patches are a lot smaller, I reintegrated all the modifications into a single patch, pushed here: http://review.whamcloud.com/4720 The other patches are abandoned. Sebastien.
          adilger Andreas Dilger made changes -
          Parent New: LU-2753 [ 17451 ]
          Severity Original: 3 [ 10022 ]
          Issue Type Original: Bug [ 1 ] New: Technical task [ 7 ]
          emoly.liu Emoly Liu added a comment -

          Oleg,

          As Keith mentioned, these patches are a great many LASSERT adds, something like LU-1961, so could you please take a look at them?

          Thanks,
          Emoly

          emoly.liu Emoly Liu added a comment - Oleg, As Keith mentioned, these patches are a great many LASSERT adds, something like LU-1961 , so could you please take a look at them? Thanks, Emoly
          sebastien.buisson Sebastien Buisson (Inactive) added a comment -

          The big patch proposed initially has been split into four smaller ones:
          http://review.whamcloud.com/4720
          http://review.whamcloud.com/4721
          http://review.whamcloud.com/4722
          http://review.whamcloud.com/4723

          sebastien.buisson Sebastien Buisson (Inactive) added a comment - The big patch proposed initially has been split into four smaller ones: http://review.whamcloud.com/4720 http://review.whamcloud.com/4721 http://review.whamcloud.com/4722 http://review.whamcloud.com/4723
          emoly.liu Emoly Liu added a comment -

          The patch has been reviewed. Since the new assetion in mdt_open.c caused recovery-small.sh test_23 and replay-single.sh test_14 failure, the patch needs to be revised further.

          emoly.liu Emoly Liu added a comment - The patch has been reviewed. Since the new assetion in mdt_open.c caused recovery-small.sh test_23 and replay-single.sh test_14 failure, the patch needs to be revised further.
          emoly.liu Emoly Liu made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          emoly.liu Emoly Liu added a comment -

          Sorry for my late reply. I am still relative new for jira.
          I will review this patch soon.

          Emoly

          emoly.liu Emoly Liu added a comment - Sorry for my late reply. I am still relative new for jira. I will review this patch soon. Emoly
          emoly.liu Emoly Liu made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]

          People

            emoly.liu Emoly Liu
            sebastien.buisson Sebastien Buisson (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: