[LU-5275] clean up technical debt for proc_dir_entry changes

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.7.0
• Labels: patch
• Severity: 3
• Assignee: John Hammond
• Reporter: Jodi Levi (Inactive)

Description

This is to address the last comment made in LU-3319 to cleanup the technical debt.

Issue Links

• is related to: LU-5983 builds broken by LU-5275 fix
• is related to: LU-4416 support for 3.12 linux kernel
• is related to: LU-3319 Adapt to 3.10 upstream kernel proc_dir_entry change

Comments

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13463
Subject: LU-5275 build: add LPROCFS to the deprecated symbol list
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f0b41cec79d7b8f86387afb94820e8e507c2b21b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13330/
Subject: LU-5275 lprocfs: sync names to upstream kernel lustre client
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a172863af11bcef474191ca40eaa479179457c08

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/12235/
Subject: LU-5275 lprocfs: remove all non-seq file functions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b66962c0f92b29353ac255400783e9b0faa9c2e3

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13341/
Subject: LU-5275 libcfs: merge params_tree.h into lprocfs_status.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 17d614c7017c41d3484b163c8d86d324335c93e0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13299/
Subject: LU-5275 lprocfs: replace LPROCFS with CONFIG_PROC_FS
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7817e4c785d075aae76b635dcf799064590833b0

[James A Simmons]

Finally finished off the patch set thanks to John Hammond. The patches to finish this are:

http://review.whamcloud.com/#/c/13299
http://review.whamcloud.com/#/c/13341
http://review.whamcloud.com/#/c/12235
http://review.whamcloud.com/#/c/13330

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13341
Subject: LU-5275 libcfs: merge params_tree.h into lprocfs_status.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b22696a65873fdb69caf2a652f3bfe266bfcb489

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13225/
Subject: LU-5275 lprocfs: reduce scope of params_tree.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f9920b4924edce1bd341622eee4281fdcd41845a

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13330
Subject: LU-5275 lprocfs: sync names to upstream kernel lustre client
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a0ab151983e0655f95f7c5b53b09054b5159578a

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13299
Subject: LU-5275 lprocfs: replace LPROCFS with CONFIG_PROC_FS
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1cd9b42ae4bfa063ddeb1d9c153b86afb1373264

[James A Simmons]

I have done exhaustive testing and looked very closely at the what states lustre procfs handling is in for the case of client and server being on the same node. I loaded lod then lov and vice versa as well as unload the modules in the two possible orders. I detected no leaks in either case. In order to fill out out proc trees we have to preform mounting/unmounting of the MDT and the client. I tried both orders of mounting and
umount and saw no issues with remove_proc_subtree. Tired various combos of mounting/unmounting and module loading/unloading. No memory leaks/disappearing directories or handling symlinks occurred. Please note this is all done on a 3.12 kernel. Also looking at detail of the procfs initialization and removal don't show a issue with remove_proc_subtree.