Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5631

Incorrect swabbing of struct llog_rec_tail

Details

    • 3
    • 15747

    Description

      llog_rec_tail is accessed directly (tail = &cr->cr_tail) in lustre_swab_llog_rec, though it comes after a variable length structure. This lead to the cr_name field of the changelog_record being shuffled and the actual tail being left untouched...

      Attachments

        Issue Links

          is related to

          New Feature - A new feature of the product, which has yet to be developed. LU-1996 Fine-grained job activity tracking using changelogs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-5631] Incorrect swabbing of struct llog_rec_tail
            pjones Peter Jones made changes -
            Labels Original: mq414 patch New: patch
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/11953/
            Subject: LU-5631 obdclass: Proper swabbing of llog_rec_tail.
            Project: fs/lustre-release
            Branch: b2_5
            Current Patch Set:
            Commit: f983fb75bb485242adc1130dfa25ff5ab8392c54

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/11953/ Subject: LU-5631 obdclass: Proper swabbing of llog_rec_tail. Project: fs/lustre-release Branch: b2_5 Current Patch Set: Commit: f983fb75bb485242adc1130dfa25ff5ab8392c54
            adilger Andreas Dilger made changes -
            Fix Version/s New: Lustre 2.5.4 [ 11190 ]
            adilger Andreas Dilger made changes -
            Labels Original: patch New: mq414 patch
            jamesanunez James Nunez (Inactive) made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            hdoreau Henri Doreau (Inactive) added a comment -

            Patch applies as is on 2.4 and 2.5, here they are:

            b2_4: http://review.whamcloud.com/#/c/11954/
            b2_5: http://review.whamcloud.com/#/c/11953/

            hdoreau Henri Doreau (Inactive) added a comment - Patch applies as is on 2.4 and 2.5, here they are: b2_4: http://review.whamcloud.com/#/c/11954/ b2_5: http://review.whamcloud.com/#/c/11953/
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-1996 [ LU-1996 ]
            adilger Andreas Dilger added a comment -

            The patch in http://review.whamcloud.com/4060 would also fix this bug and would be better to land for master.

            adilger Andreas Dilger added a comment - The patch in http://review.whamcloud.com/4060 would also fix this bug and would be better to land for master.
            adilger Andreas Dilger made changes -
            Priority Original: Minor [ 4 ] New: Major [ 3 ]
            adilger Andreas Dilger made changes -
            Fix Version/s New: Lustre 2.7.0 [ 10631 ]

            People

              jamesanunez James Nunez (Inactive)
              hdoreau Henri Doreau (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: