[LU-6418] Simplify code of ll_direct_rw_pages

• Type: Improvement
• Resolution: Fixed
• Priority: Trivial
• Labels: patch
• Assignee: Jinshan Xiong (Inactive)
• Reporter: wu libin (Inactive)

Description

In function ll_direct_rw_pages, the cl_page_find will return a cl_page with cp_type of CPT_TRANSIENT for sure. And we will not cache this type of cl_page anymore.

So, i think we could remove the code of the logical when the cp_type is equal CPT_CACHABLE which is the code need in old version that cached the cl_page into the radix tree no matter what the type is.

Comments

[Jinshan Xiong (Inactive)]

The work should be already in Lustre.

[wu libin (Inactive)]

sure, thanks!

[Jinshan Xiong (Inactive)]

indeed, I forgot that we have changed cl_page_find() implementation. Yes, your patch is correct.

[wu libin (Inactive)]

Hi, Jinshan, from the code of cl_page_find, it seems that cp_type of the cl_page impossible to be CPT_CACHEABLE here.So the codes of the "if (clp->cp_type == CPT_CACHEABLE)" branch are redundant, right? Please take a look at it again, sorry if i have missed something.

[Jinshan Xiong (Inactive)]

Please reopen this ticket if anything new comes up.

[Peter Jones]

Jinshan has provided feedback on the patch in gerrit

[Gerrit Updater]

Wu Libin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14288
Subject: LU-6418 llite: Simplify code of ll_direct_rw_pages
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 21771b2aac89aa8ae6f24d096ed536f3b01f18d6