[LU-6512] ll_dir_ioctl has some pretty strange code now.

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Labels: easy patch
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

smatch highlighted thid interesting piece in ll_dir_ioctl that results from a bit of code change by commit 60e07b972114df24105a3a1bfa7365892f72a4a7 LU-4690:

                rc = ll_dir_getstripe(inode, (void **)&lmm, &lmmsize, &request,
                                      valid);
                if (rc != 0)
                        GOTO(finish_req, rc);

                /* Get default LMV EA */
                if (lum.lum_magic == LMV_USER_MAGIC) {
                        if (rc != 0)
                                GOTO(finish_req, rc);

note the two identical comparisons.
Should we take the other one down?

Comments

[Joseph Gmitter (Inactive)]

Landed to master for 2.9.0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/18027/
Subject: LU-6512 llite:ll_dir_ioctl cleanup of redundant comparisons
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c341ac9083c1764675c92363e1dd8bcd3223788a

[Gerrit Updater]

Parinay Kondekar ([e-mail]) uploaded a new patch: http://review.whamcloud.com/18027
Subject: LU-6512 ll_dir_ioctl cleanup of redundant comparisions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 909db31ed1407f266765a7575f3dd7a2f91cd4aa

[Ulka Vaze (Inactive)]

Hi,
this seems to be some merging issue.
I will check and update.

-Ulka