[LU-8095] switch LNET_* static function names to lower case

• Type: Bug
• Resolution: Won't Fix
• Priority: Minor
• Affects Version/s: Lustre 2.8.0
• Labels: patch
• Severity: 3
• Assignee: Amir Shehata (Inactive)
• Reporter: Sebastien Buisson (Inactive)

Description

Replace the upper-case names with lower-case names for the following static inline functions from LNet:
LNET_NIDADDR
LNET_NIDNET
LNET_MKNID
LNET_NETNUM
LNET_NETTYP
LNET_MKNET

Comments

[Sebastien Buisson (Inactive)]

Hi,

I am proposing this patch following Andreas' comment:
http://review.whamcloud.com/#/c/19792/2/lustre/ldlm/ldlm_lib.c@469

[James A Simmons]

I know they frown on camel case which we also have exported in our LNet layer. It is the same problem in that if we remove the camel case naming of the LNet functions then we break external modules. As for all capital name functions I don't know if they are so strict. I never seen checkpatch complain about this.

[Doug Oucharek (Inactive)]

Is this being done in response to a kernel coding guideline?

[James A Simmons]

This change makes me nervous. These functions are exposed to external software stacks (Cray's DVS for example) so this change would break them very badly.

[Joseph Gmitter (Inactive)]

Hi Doug,
Can you please have a look at the patch?
Thanks.
Joe

[Gerrit Updater]

Sebastien Buisson ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19964
Subject: LU-8095 lnet: switch LNET_* static functions to lower case
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 02ef17b50e0c99795cad88cfb1f8cd18cfd065a1