[LU-9152] New static analysis issues in v2_9_53_0-27-gf913720

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.10.0
• Labels: kw
• Severity: 3
• Assignee: Steve Guminski (Inactive)
• Reporter: Dmitry Eremin (Inactive)

Description

Found 2 new static analysis issues in v2_9_53_0-27-gf913720:

1. Null pointer may be passed to function that may dereference it
   • lustre/mgc/mgc_request.c: in config_log_add, Null pointer 'sptlrpc_cld' that comes from line 315 may be passed to function and can be dereferenced there by passing argument 1 to function 'config_log_put' at line 419.
2. Null pointer may be passed to function that may dereference it
   • lustre/mgc/mgc_request.c: in config_log_add, Null pointer 'params_cld' that comes from line 316 may be passed to function and can be dereferenced there by passing argument 1 to function 'config_log_put' at line 413.

The list of commits since the previous build v2_9_52_0-74-gc39d13d:

f913720	LU-8773 llite: refactor lov_object_fiemap()
8d27681	LU-8767 llite: Improve proc file text in lproc_llite.c
db99971	LU-9100 lnet: lctl net down success when lnet not loaded
40fe3cd	LU-8703 libcfs: remove usless abstraction
ad8f669	LU-8888 clio: remove unused members from struct cl_thread_info
c152f7b	LU-7670 mdt: allow changelog commands to return errors
1f58cac	LU-9019 mdt: use 64-bit timestamps for rename stats
6e67953	LU-8560 build: announce linux kernel 4.6.7 support
dad9ce4	LU-9125 test: Correct setstripe -s option
2b16d2d	LU-9123 test: correct setstripe options in layout test
603aa7a	LU-9094 o2iblnd: reconnect peer for REJ_INVALID_SERVICE_ID
81e010d	LU-9115 llite: buggy special handling on MULTIMODRPCS
540fcd2	LU-4423 mdc: use 64-bit timestamps for mdc
19f057c	LU-9101 kernel: kernel update [SLES11 SP4 3.0.101-94]
adf08bd	LU-8066 ldlm: move server side /proc/fs/lustre/ldlm to sysfs
9d13d28	LU-8947 test: fix getting OST name at sanity test_253
a1c8e27	LU-9125 utils: Postpone deprecation of some options.
57ba9de	LU-9081 config: don't attach sub logs for LWP
723f400	LU-5170 utils: Add support for --list-commands option
70e9d4e	LU-6210 utils: Change positional struct initializers to C99
e4761eb	LU-6499 obdclass: obdclass module cleanup upon load error
3dc5a9f	LU-8550 test: fix problems of conf-sanity test_32
d891911	LU-5969 lustreapi: allow "version" without "lustre:"
eecf886	LU-9059 utils: skip label check for client
04794b3	LU-8526 tests: ensure all OSTs active for allocations
05ad99f	LU-6142 lnet: remove most of typedefs from LNet headers
1e42682	LU-9040 scrub: handle group boundary properly
a4bbf41	New tag 2.9.53
f03c8b1	LU-9032 tests: syntax error in cleanup_test32_mount
3403364	LU-8843 client: fix all less than 0 comparison for unsigned values
9ab8061	LU-9078 lnet: Fix route hops print
cfa981f	LU-8974 osd-ldiskfs: increase supported ldiskfs fs size
d2c4033	LU-5620 ptlrpc: Add QoS for opcode in NRS-TBF
74d0cf9	LU-9019 osd: migrate osd-ldiskfs thandle stats to 64 bit time
ad0a085	LU-8702 tests: parallel execution of IOR and MDTEST added.

Issue Links

• is related to: LU-4629 Issues found by static analysis tools

Comments

[Peter Jones]

Landed for 2.10

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/25854/
Subject: LU-9152 mgc: Remove unnecessary checks for config_log_put()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ffde9ae4784fdb045eae8438aa0c179db6172232

[Steve Guminski (Inactive)]

Changeset 24262 merged on March 9 included a check in config_log_put() for a NULL parameter.  Can this ticket be closed without any further code changes now that config_log_put() cannot dereference a NULL pointer?

[Gerrit Updater]

Steve Guminski ([e-mail]) uploaded a new patch: https://review.whamcloud.com/25854
Subject: LU-9152 mgc: Fix NULL pointers found by static analysis
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 19adeee562eef6a028a163c719b41adb6d249cc4

[Steve Guminski (Inactive)]

I'm currently working another ticket, but I'll add this to my queue and pick it up as soon as I can.

[Joseph Gmitter (Inactive)]

Hi Steve,

Would you be able to pick up this one?

Thanks.
Joe